search

thomasloven / lovelace-card-mod

🔹 Add CSS styles to (almost) any lovelace card
MIT License
1.08k stars 168 forks source link

Remove a border for 2022.11 #231

Closed ildar170975 closed 1 year ago

ildar170975 commented 1 year ago

Removed a border displaying in 2022.11

EuleMitKeule commented 1 year ago

Please merge this, my UI looks really bad with all those borders right now. 😅

EuleMitKeule commented 1 year ago

@thomasloven Is this repo still maintained? I bet tons of people experience this ugly border bug and this is a quick and easy fix would it be merged.

ildar170975 commented 1 year ago

experience this ugly border bug

Technically, this is not card-mod's bug. This is an incompatibility with a changed HA, consequences of ill-conceived decision in HA design.

EuleMitKeule commented 1 year ago

@ildar170975 I absolutely agree. Still some help from the maintainer would be much appreciated! Could you by any chance tell me, how I could fix this in my configuration until this PR is merged? Do I have to fork card-mod and build a fixed version or is there a simpler way?

ildar170975 commented 1 year ago

Try applying this style for mod-card:

  ha-card {
    border: none;
    transition: none;
  }

You need to do it for EVERY mod-card in your setup.

EuleMitKeule commented 1 year ago

@ildar170975 I just noticed, I'm actually not using any mod-cards. This seems to happen for every button-card I use, so it's not caused by card-mod at all. I will check the button-card repo for a fix. Apparently card-mod is not the only plugin experiencing this issue.

EuleMitKeule commented 1 year ago

Putting this ha-card-border-width: 0 into your theme file fixes the issue.

ildar170975 commented 1 year ago

Putting this ha-card-border-width: 0 into your theme file fixes the issue.

Not exactly

ildar170975 commented 1 year ago

I'm actually not using any mod-cards. This seems to happen for every button-card I use, so it's not caused by card-mod at all

Since you are NOT using mod-card, then surely your issues are related to other cards. So far I noticed issues with bar-card, stack-in-card.

PeteCooney commented 1 year ago

As a temporary workaround, until this pull request gets approved, it's possible to manually add this change to the card-mod.js file. Note though that you'll also want to update the card-mod.js.gz compressed version as well or some (all?) browsers won't actually pick up the change. Also ensure that you clear your browser cache after making the change.

Standard disclaimer: I accept no responsibility if you break anything by manually editing these (or any other) files.