thomasloven / lovelace-fold-entity-row

🔹 A foldable row for entities card, containing other rows
MIT License
561 stars 37 forks source link

Unfolding shows all entities before the animation starts #196

Closed julienlarivee closed 2 years ago

julienlarivee commented 2 years ago

My Home Assistant version: 2021.11.5

Fold-entity-row version (FROM BROWSER CONSOLE): 20.0.12

What I am doing: Unfolding a row.

What I expected to happen: Showing the entities inside the fold one by one as the animation goes down.

What happened instead: All the entities inside the fold appears, then the fold animation starts.

Here is a printscreen during the unfolding with the entity repeated a couple of time so it can be easyer to see: 12

Minimal steps to reproduce: Unfolding a row. Having many entities in the fold-entity-row may help to see it.

type: entities
entities:
  - automation.avertissement_lavage_termine
  - type: custom:fold-entity-row
    head:
      type: section
      label: Paramètres
    entities:
      - input_number.temps_lavage_termine
title: Salle de lavage
show_header_toggle: false

Error messages from the browser console: None


By putting an X in the boxes ([X]) below, I indicate that I:

thomasloven commented 2 years ago

What browser are you using?

julienlarivee commented 2 years ago

Google chrome Version 96.0.4664.45 (Build officiel) (64 bits)

Edit: Just tried it now with Edge and Firefox and same thing is happening.

fotis3d commented 2 years ago

I confirm this is happening to me too.

Shamshala commented 2 years ago

Same here.

Basically the same happens even when one tries to fold it (fold animation at first, then entities disappear).

ildar170975 commented 2 years ago

have to confirm the issue. Win10x64, Chrome

mikosoft83 commented 2 years ago

Vivaldi user (chromium based) gone through several updates, Edge as well. I'm using folds extensively and every single one does it.

thomasloven commented 2 years ago

Please try 20.0.13

fotis3d commented 2 years ago

There is a new version ? I will try as soon as HACS prompts me. :). Thanks.

mikosoft83 commented 2 years ago

Please try 20.0.13

Just tested, works as expected! Great work as always, Thomas

julienlarivee commented 2 years ago

@thomasloven works great on the first fold, but is still there with nested fold. On 20.0.13 and cache cleared.

Here is an example:

type: entities
entities:
  - entity: input_boolean.gerer_panne_electrique
    name: Électrique
  - entity: input_boolean.gerer_panne_internet
    name: Internet
  - type: custom:fold-entity-row
    head:
      type: section
      label: Paramètres
    entities:
      - type: custom:fold-entity-row
        head:
          type: section
          label: Électrique
        entities:
          - entity: input_number.temps_verification_panne_electrique
            name: Temps de vérification
      - type: custom:fold-entity-row
        head:
          type: section
          label: Internet
        entities:
          - entity: input_number.temps_verification_panne_internet
            name: Temps de vérification
title: Pannes
show_header_toggle: false

The sections "Électrique" and "Internet" are still doing it.

thomasloven commented 2 years ago

Should be fixed now.

julienlarivee commented 2 years ago

Looks good for me. Thanks @thomasloven

fotis3d commented 2 years ago

Is this update coming through HACS or should we do it only manually ?