thomasloven / lovelace-fold-entity-row

🔹 A foldable row for entities card, containing other rows
MIT License
561 stars 37 forks source link

fold-entity-row glitches on iOS if it contains another fold-entity-rows #199

Closed ildar170975 closed 2 years ago

ildar170975 commented 2 years ago

My Home Assistant version: 2021.12.6

Fold-entity-row version (FROM BROWSER CONSOLE): 20.0.12

What I am doing: Expanding a fold-entity-row on iPad client. This row contains another fold-entity-rows.

What I expected to happen:

  1. Row is expanded.
  2. All inserted rows are visible & work properly.

What happened instead: iPad Air 2 (iOS 15.x): the last row is clipped: изображение

Btw, what we see on iPhone 5S (iOS 12.x): Basically I see this (the picture including other rows above the test card): изображение (related to another issue - https://github.com/thomasloven/lovelace-fold-entity-row/issues/198), but if I managed to display it (after cleaning cache, reloading App) then I just cannot expand some rows (at least containing another fold-entity-rows, button-rows and other conventional rows supported in Entities card).

Minimal steps to reproduce:

type: entities
entities:
  - sun.sun
  - type: custom:fold-entity-row
    head:
      type: section
      label: section
    padding: 10
    open: false
    entities:
      - sun.sun
      - type: custom:fold-entity-row
        head:
          type: section
          label: section
        padding: 10
        open: false
        entities:
          - entity: sun.sun
          - entity: sun.sun
      - type: custom:fold-entity-row
        head:
          type: section
          label: section
        padding: 10
        open: false
        entities:
          - entity: sun.sun
          - entity: sun.sun

Error messages from the browser console: no

By putting an X in the boxes ([X]) below, I indicate that I:

ildar170975 commented 2 years ago

Do not see it in 12.0.4

thomasloven commented 2 years ago

Great! I forgot to ping this issue when I updated - sorry.

ildar170975 commented 2 years ago

Thomas, unfortunately I see a glitch on iPhone 5s (iOS 12.5.5).

This is how it looks in iPad Air 2 (iOS 15.x): image

And how it looks on iPhone when folded: image Note - the next card is a vertical-stack with a markdown card. When unfolded - there is a glitch: image I see this glitch ALWAYS.

thomasloven commented 2 years ago

Guess I'm dusting off the ipad air 1 again...

ildar170975 commented 2 years ago

So, on iPad Air 2 - OK, on iPhone 5S - not OK...

dapuzz commented 2 years ago

Not sure this is fixed 🙃 18A602AB-01CC-424E-ADE1-8158052FA140 iPhone XR iOS 13

thank you

thomasloven commented 2 years ago

Should be fixed now.

ildar170975 commented 2 years ago

Now it is broken even for iPad Air 2 (iOS 15.x) and even for a case "fold-entity-row does NOT contain another fold-entity-row" (((

image

type: entities
entities:
  - entity: sun.sun
    secondary_info: last-changed
  - type: custom:fold-entity-row
    head:
      entity: sun.sun
      secondary_info: last-changed
    padding: 5
    no_animation: true
    open: true
    entities:
      - entity: sun.sun
        secondary_info: last-changed
      - entity: sun.sun
        secondary_info: last-changed
  - type: custom:fold-entity-row
    head:
      type: section
      label: Section
    padding: 5
    open: true
    group_config:
      secondary_info: last-changed
      icon: mdi:desk-lamp
    entities:
      - sun.sun
      - sun.sun
  - type: section
  - type: custom:fold-entity-row
    head:
      entity: input_boolean.test_boolean
    padding: 50
    open: false
    entities:
      - entity: sun.sun
      - entity: sun.sun
        secondary_info: last-changed

Mobile App was tested after resetting a frontend cache.

skynet01 commented 2 years ago

I am getting similar issues as @dapuzz on 2.0.15 release, the 2.0.14 works fine for me. Seems to effect Safari / iOS

thomasloven commented 2 years ago

I pulled 2.0.15 back and rereleased. If you were very quick to install it, you may need to remove fold-entity-row completely and reinstall.

ildar170975 commented 2 years ago

What I did is:

  1. Uninstall fold-entity-row in HACS.
  2. Restart HA.
  3. Install fold-entity-row in HACS.
  4. Reset frontend cache on iPhone.

And still the card is displayed malformed.

Shall I do additional actions when uninstalling fold-entity-row?

garyak commented 2 years ago

Seeing this on 2.0.15. iOS 15.3, HA Companion App 2021.12.1, HA Core 2021.12.10 Screenshot 2022-01-30 at 10 53 54 AM .

Mariusthvdb commented 2 years ago

yes and also on dev20220130 and desktop for that matter

Schermafbeelding 2022-01-30 om 22 00 11

I revert to 20.0.12

thomasloven commented 2 years ago

image

This photo shows 20.0.15 running on Firefox under Linux, Chrome under linux, Safari under macOS 10.15.7, Safari under iOS 15.3, Home Assistant Companion under iOS 14.4.2 and Safari under iOS 12.5.5.

All with no trace of the problems described. Also all showing a visual difference that's unique to 20.0.15 but is absent from all screenshot posted in #192, #199 and #206.

I've made a new release (2.1.0) to maybe force HACS to update correctly.

garyak commented 2 years ago

2.1.0 fixed my issue. Thank you Thomas.

ildar170975 commented 2 years ago

Great! Thank you, Thomas!