thomasloven / lovelace-layout-card

🔹 Get more control over the placement of lovelace cards.
MIT License
1.05k stars 125 forks source link

Unable to enter edit mode with non-default layout #153

Closed jackwilsdon closed 3 years ago

jackwilsdon commented 3 years ago

My Home Assistant version: 2021.7.1

Layout-card version (FROM BROWSER CONSOLE): 2.3.0

What I am doing: editing a dashboard with non-default layout

What I expected to happen: the dashboard would enter edit mode properly

What happened instead: the dashboard does not properly enter edit mode:

screenshot showing issue

Minimal steps to reproduce:

  1. Create a dashboard with a non-default layout and at least one card:
    views:
      - type: custom:masonry-layout
        cards:
          - type: button
  2. Reload the page (this is important - the issue does not appear until after a reload)

By putting an X in the boxes ([X]) below, I indicate that I:

magenbrot commented 3 years ago

same here. As a workaround: the edit button appears when entering edit-mode on a different dashboard (with default layout) and then switching back to the dashboard with the custom-layout.

disforw commented 3 years ago

Same issue here, I removed this plug-in and issue went away.

CoryAlbrecht commented 3 years ago

Me as well. Change layout and the problem goes away and the edit button returns. but I really want that different layout as the default is too limiting.

Protoncek commented 3 years ago

An update for this problem: it seems that this problem exists only if lovelace layout is set to anything but default. I have one lovelace borad set to "vertical" (for my mobile phone) i have this problem. If i set layout back to default all is ok and "edit" bars appear immediately. So, going to ANY lovelace with default layout causes all other pages to go back to normal. But only until browser is closed and re-opened...

sesquipedality commented 3 years ago

Also observing this issue. Have been working around by changing the layout to default then back to horizontal, but switching to a default tab sounds easier.

Protoncek commented 3 years ago

Today i experimented a bit again, and i can say that by removing "layout-card" problem completely dissapears. So, it's definitely this card's problem. So, i guess it'll have to be removed until this issue is resolved...

@thomasloven : do you have any clue what could be the problem?

thomasloven commented 3 years ago

This should be fixed in release 2.3.1

magenbrot commented 3 years ago

I can confirm that it's working again. Thanks for the fix, @thomasloven!