2022.10.0 beta compatibility - view configuration no longer displays layout config options

kulmegil commented 1 year ago

My Home Assistant version: 2022.10.0b0

Layout-card version: 2.4.2

What I am doing:

Testing next Home Assistant beta.

What I expected to happen:

Layout card custom layouts and layout configuration controls visible in view configuration dialog in edit mode.

What happened instead:

Vanilla HA dialog is shown.

Minimal steps to reproduce:

1) enter edit mode 2) edit any view configuration

Error messages from the browser console:

23:40:05.277 Uncaught (in promise) TypeError: can't access property "options", i.selector.select is undefined
    _schema https:///my.home-assistant.io:8123/hacsfiles/lovelace-layout-card/layout-card.js?hacstag=156434866242:215
    value https:///my.home-assistant.io:8123/frontend_latest/e2bd3888.js:532
    update https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    performUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    scheduleUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    _$EC https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    requestUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    firstUpdated https:///my.home-assistant.io:8123/hacsfiles/lovelace-layout-card/layout-card.js?hacstag=156434866242:215
    _$AE https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    performUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    scheduleUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    _$EC https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249
    requestUpdate https:///my.home-assistant.io:8123/frontend_latest/app.d41312b9.js:1249

By putting an X in the boxes ([X]) below, I indicate that I:

[X] Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
[X] Have made sure I am using the latest version of the plugin.
[X] Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.
[X] Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

piitaya commented 1 year ago

The subview option has been added. Look like it break the patch on the view editor.

But YAML support has been added to this editor. So I don't think this patch is needed anymore. WDYT @thomasloven ?

kulmegil commented 1 year ago

I did fix that with few simple tweaks to hui-view-editor.ts (sorry I haven't made a pull request in a long time and it was easier for me to write the code in comment)

    this._schema = (localize) => {
      const retval = this._oldSchema(localize);
      const typeSelector = retval.find(s => s.name === 'type');
      const layoutSelector = retval.find(s => s.name === 'layout');
      if (layoutSelector || !typeSelector) return retval;
      typeSelector.selector.select.options.push(
        ...LAYOUT_CARD_SELECTOR_OPTIONS
      );
      retval.splice(retval.indexOf(typeSelector) + 1, 0, {
        name: "layout",
        selector: { object: {} },
      });
      return retval;
    };

I justspotted the new yaml button. Personally I would prefer the controls to be visible straight away whenever I open the dialog.

joggs commented 1 year ago

Still broken in the 2022.10 release