search

thomasloven / lovelace-template-entity-row

🔹 Display whatever you want in an entities card row.
MIT License
210 stars 16 forks source link

Fixing issues with missing icons + active color #101

Closed michalolborski closed 1 year ago

michalolborski commented 1 year ago

missing icons after HA 2023.2.0, issues: https://github.com/thomasloven/lovelace-template-entity-row/issues/100

wrong active color after HA 2023.1.0, issues: https://github.com/thomasloven/lovelace-template-entity-row/issues/95 https://github.com/thomasloven/lovelace-template-entity-row/issues/94

Erelen-Laiquendi commented 1 year ago

Doesn't work without entity parameter :( It shows blank row.

ildar170975 commented 1 year ago

@Erelen-Laiquendi

Doesn't work without entity parameter

This is my case: https://github.com/thomasloven/lovelace-template-entity-row/issues/100#issuecomment-1423381429 an icon is NOT displayed if no entity is defined:

      type: custom:template-entity-row
      state: yyy
      name: xxx
      icon: mdi:car

Do you mean that this PR does not solve this particular issue? Cannot test it myself... Need to have a compiled js-file to install.

michalolborski commented 1 year ago

@Erelen-Laiquendi , @ildar170975 - hope it explains everything ;)

image

this is how this component is working after this PR

ildar170975 commented 1 year ago

@michalolborski Seems to be working! Could you share a compiled js-file? For testing, ofc

TheHolyRoger commented 1 year ago

@michalolborski Can I suggest you stick your own fork on HACS? If you're not happy to maintain it maybe I will instead... @thomasloven seems to have dropped this one I think?

michalolborski commented 1 year ago

@michalolborski Can I suggest you stick your own fork on HACS? If you're not happy to maintain it maybe I will instead... @thomasloven seems to have dropped this one I think?

you can take over if you like :)

TheHolyRoger commented 1 year ago

Fixed in my fork here, feel free to add it as a custom repo in HACS: https://github.com/TheHolyRoger/lovelace-template-entity-row

Remove this one first then add mine 👍