thomasmichaelwallace / serverless-better-credentials

Better AWS credentials resolution plugin for serverless
MIT License
54 stars 9 forks source link

Fix new SSO connection regressions #29

Closed guiyom-e closed 12 months ago

guiyom-e commented 1 year ago

Fix new SSO connection regressions introduced in https://github.com/thomasmichaelwallace/serverless-better-credentials/pull/26

Should close https://github.com/thomasmichaelwallace/serverless-better-credentials/issues/18, https://github.com/thomasmichaelwallace/serverless-better-credentials/issues/27 and https://github.com/thomasmichaelwallace/serverless-better-credentials/issues/28

guiyom-e commented 1 year ago

@tonyvdv and @alaexeyshustov this PR should fix your issues, may you check it ?

@thomasmichaelwallace v1.2.1 may be released I suggest!

MichaelLebrand commented 12 months ago

@thomasmichaelwallace sorry to push you a bit on this but could we go ahead and merge this? Thanks!!

tobim commented 12 months ago

Is there any way to use this branch in the meantime?

guiyom-e commented 12 months ago

Is there any way to use this branch in the meantime?

@tobim : you may clone the repo, install and build it (yarn && yarn build), and then link it to your own package.json instead of using the default npm version.

It can be done with a yarn link or a direct file link: "serverless-better-credentials": "file:[path to serverless-better-credentials folder]"

tobim commented 12 months ago

@guiyom-e: Thanks, after following your steps and running npm install in my project serverless complains:

Serverless plugin "serverless-better-credentials" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file. Run "serverless plugin install -n serverless-better-credentials" to install it.
thomasmichaelwallace commented 12 months ago

OK- although last time I did this it broke everything 😉

thomasmichaelwallace commented 12 months ago

Now released as 1.2.1.

MichaelLebrand commented 12 months ago

OK- although last time I did this it broke everything 😉

hehe fair point, will see if we run into anything in the coming days/weeks. Thanks for pushing the buttons anyway!