thomasmichaelwallace / serverless-better-credentials

Better AWS credentials resolution plugin for serverless
MIT License
54 stars 9 forks source link

feat: new enabled flag #33

Closed aldenquimby closed 9 months ago

aldenquimby commented 9 months ago

This is my first PR, so please let me know if there's anything else you'd like to see in terms of docs or tests!

Why

How

aldenquimby commented 9 months ago

@thomasmichaelwallace how does this PR look? My team is excited to use better-credentials once we have this flag. Thank you!

thomasmichaelwallace commented 9 months ago

@aldenquimby take a look at my suggestion - that .custom is not a guaranteed key.

And then we're good to go I think.

aldenquimby commented 9 months ago

@thomasmichaelwallace I don't see your suggestion, but I can guess at it based on that comment! Just pushed an update that makes .custom optional

aldenquimby commented 9 months ago

Thanks @thomasmichaelwallace ! Excited for this to release 🚀

thomasmichaelwallace commented 8 months ago

Now released - https://github.com/thomasmichaelwallace/serverless-better-credentials/releases/tag/v1.3.0

aldenquimby commented 8 months ago

@thomasmichaelwallace thank you! Just upgraded and it looks good