Set tests to OFF if TPIE is in a submodule

thomasmoelhave / tpie

Templated Portable I/O Environment

Other

112 stars 24 forks source link

Set tests to OFF if TPIE is in a submodule #249

Closed SSoelvsten closed 2 years ago

SSoelvsten commented 2 years ago

One could argue both ways: when you just run make on a project with TPIE as its dependency should tests be compiled and run for TPIE too or should you trust your TPIE dependency just to work? I'd advocate for the latter (primarily to not having to wait so long).

Of course, in most cases I specify what target I want to create, but when I want to run make && make install on my project, I would not want to wait for all TPIE's unit tests to compile.

antialize commented 2 years ago

Why not just do do the following in the use software?

option(COMPILE_TEST OFF)
include_directories(tpie)

SSoelvsten commented 2 years ago

Valid counter argument, I didn't think about that. xD

Question though then is, whether it should have a less generic name? Or is it custom to have all tests in a COMPILE_TEST variable that turns on or off all subprojects too?