search

thomasnordquist / MQTT-Explorer

An all-round MQTT client that provides a structured topic overview
https://mqtt-explorer.com
Other
2.99k stars 287 forks source link

Project abandoned? #730

Open bj00rn opened 1 year ago

bj00rn commented 1 year ago

Thanks for this awesome app!

Is this project abandoned?

A lot of open issues and PRs.

ilgrank commented 1 year ago

Yes, the author is not updating the code since years and basically is also not very active here, his last activity has been a reply on this issue: https://github.com/thomasnordquist/MQTT-Explorer/issues/683#issuecomment-1357485710 on Dec 19, 2022. Lots of people asking for his return on the project or a change to the licensing that would allow others to continue developing it, but alas, he's not answering anymore.

bj00rn commented 1 year ago

@ilgrank thanks, sad to hear..

@thomasnordquist would you consider loosening the license for this awesome app, so people can continue maintaining it?

backupandforkacc commented 1 year ago

Anyone with a good alternative to the software?

XtremeOwnageDotCom commented 1 year ago

Anyone with a good alternative to the software?

Despite being unmaintained for a few years at this point, It's still arguably one of the best solutions out there.

bj00rn commented 1 year ago

@ilgrank thanks, sad to hear..

@thomasnordquist would you consider loosening the license for this awesome app, so people can continue maintaining it?

PING @thomasnordquist, sorry for being a pain in the ***. Just can't wrap my head around this amazing piece of tech being unmaintained!

jeeftor commented 1 year ago

I suspect at some point somebody will just fork it and move it forward...

adamalfath commented 1 year ago

Anyone with a good alternative to the software?

MQTTX is quite good

jeeftor commented 1 year ago

I still prefer this one unfortunately

ilgrank commented 8 months ago

@jeeftor : no update from @thomasnordquist or @snordquist , right?

jeeftor commented 8 months ago

Of course no update

jeeftor commented 8 months ago

Somebody just needs to fork this and the community will likely jump in to help

XtremeOwnageDotCom commented 8 months ago

Somebody just needs to fork this and the community will likely jump in to help

The issue, is the license.

https://github.com/thomasnordquist/MQTT-Explorer?tab=License-1-ov-file#readme

https://www.tldrlegal.com/license/creative-commons-attribution-noderivatives-4-0-international-cc-by-nd-4-0

Long story short, the license prevents others from modifying, and then sharing this code/project.

XtremeOwnageDotCom commented 8 months ago

So, unless @thomasnordquist changes to a less restrictive license, or decides to start maintaining this project again-

It is as good as dead.

jeeftor commented 8 months ago

Doesn't the license only come into play if it's enforced? So if it's abandoned who is going to enforce it

bj00rn commented 8 months ago

Doesn't the license only come into play if it's enforced? So if it's abandoned who is going to enforce it

That's not how licenses works though.. The Non-derivative license prevents us from forking and sharing the fork.

Beside the potentially legal exposure (however unlikely) putting effort into a project without a proper license is a no-go.

jeeftor commented 8 months ago

So what if the maintainer died? (Hypothetically)

Jackfritt commented 8 months ago

I think his family took it over to this one... https://mqtt-explorer.com/ https://github.com/thomasnordquist/MQTT-Explorer

MartinRiddar commented 8 months ago

@jeeftor He isn't dead, he's just not very active on github anymore, he did a single pull request in the last year (November). @Jackfritt If you check the Github link for that project it links here...

scubanarc commented 7 months ago

Doesn't the license only come into play if it's enforced? So if it's abandoned who is going to enforce it

That's not how licenses works though.. The Non-derivative license prevents us from forking and sharing the fork.

Beside the potentially legal exposure (however unlikely) putting effort into a project without a proper license is a no-go.

If you rewind the clock 5 years, it was AGPL:

https://github.com/thomasnordquist/MQTT-Explorer/tree/ea7994dad945dba2291d097ea233def9942761e3?tab=readme-ov-file

XtremeOwnageDotCom commented 7 months ago

If you rewind the clock 5 years, it was AGPL:

https://github.com/thomasnordquist/MQTT-Explorer/tree/ea7994dad945dba2291d097ea233def9942761e3?tab=readme-ov-file

Doesn't look like there are that many differences in the last 5 years. Perhaps we should fork that to a new project.

scubanarc commented 7 months ago

Yes, someone should fork it from 5 years ago when it was still AGPL, everyone move their PR's, and then we all continue on forward with this project.

steveja commented 7 months ago

Maybe it's me - but I can't build from the git repo. 'yarn' complains that the older packages are needed (my interp'). So I think this is totally dead as an open project.

jeeftor commented 7 months ago

So the license got added in this commit (2019).

https://github.com/thomasnordquist/MQTT-Explorer/commit/9320fa252e0a630f3d933fbb3bcd83847ca6d381

XtremeOwnageDotCom commented 7 months ago

So the license got added in this commit (2019).

9320fa2

  • Does that mean anything prior to this commit is fair game?

Basically, up to the limitations of its prior license

thomasnordquist commented 7 months ago

Hello there, for me time is a very limited resource, and at the end of the day I try to finally close my laptop. This is one reason I do not maintain this project (or any other private projects) at the moment.

The license will stay like this for now, the main goal is to protect this project to be commercially distributed in any way.

My previous experiences with collborators was sadly not optimal, therefore I was discouraged to pursue this further. I will request @bj00rn to be a maintainer of this project (since he already spend some effort to get in contact with me).

I will also help with the distribution of new versions.

There are a few things which are kind of urgent for this project:

scubanarc commented 6 months ago

Hey Thomas, glad to hear you're still around! Thanks again for this awesome program. It really is the best MQTT frontend out there and I use it daily. Amazing work!

The license will stay like this for now, the main goal is to protect this project to be commercially distributed in any way.

That's very unfortunate. Please reconsider this.

It was AGPL once before, so it's already out there to be abused by companies. Keeping it CC-BY-ND 4.0 just hurts the community by preventing an active user from forking and improving it.

As of right now, it's been dead for 2 years. There are 64 PRs and no-one to merge them.

I do hope that @bj00rn is able to maintain it, but please consider opening up the license.

GeekyTim commented 6 months ago

@thomasnordquist, I'm sorry to hear you have been burnt by previous collaborations, and understand your stance. Please remember that many of us here in this community don't always have the best communication methods and often cannot see other's reasons and point of view. Being recently diagnosed as Autistic myself, I do know I have not always been the best communicator in the past.

I will not comment on your choice of license etc. That is your choice alone.

@bj00rn, I welcome any work you do on this tool. I am looking forward in particular to see it working on the Raspberry Pi, my current main machine!

jeeftor commented 6 months ago

Is there a license which prohibits commercial use but opens up for open source - forking etc? Or does such a thing not exist?

XtremeOwnageDotCom commented 6 months ago

Is there a license which prohibits commercial use but opens up for open source - forking etc? Or does such a thing not exist?

Creative Commons NonCommercial

https://creativecommons.org/licenses/by-nc/4.0/deed.en

bj00rn commented 6 months ago

@thomasnordquist thanks for the invite! I wasn't really expecting to be assigned maintainer but merely hoping to re-open a discussion on how to move this awesome project forward. That being said, I am willing to invest some time and effort to get this project up to date and try to get some momentum going here.

Let's get the janitorial side of things up to date first so we can do a new release.

Additionally there are a few long due, low hanging PRs that seem like they could be merged without any major considerations.

Disclaimer Im pretty well versed in react+redux but my skills concerning electron are basic at the very best, so please be kind/patient here.

If some of you want to contribute feel free to open PRs. This will have to be a team effort going forward.

micw commented 6 months ago

Great to see that the project is not abandoned!

I was able to fix the certificate issue locally by upgrading electron to the latest release (29.0.1). I also updated electron-builder to 24.12.0, no idea if that matters. To build with a recent node version, I also added export NODE_OPTIONS=--openssl-legacy-provider && in front of the commands in the "build" script definition.

Important was to start from git tag 355e9177fc1be24bd1eb516772aede3877a7de32 which was the tag the latest beta-release was made from. The changes after caused several issues. So maybe branching from there would make sense for a hotfix release.

bj00rn commented 6 months ago

Great to see that the project is not abandoned!

I was able to fix the certificate issue locally by upgrading electron to the latest release (29.0.1). I also updated electron-builder to 24.12.0, no idea if that matters. To build with a recent node version, I also added export NODE_OPTIONS=--openssl-legacy-provider && in front of the commands in the "build" script definition.

Important was to start from git tag 355e917 which was the tag the latest beta-release was made from. The changes after caused several issues. So maybe branching from there would make sense for a hotfix release.

What errors du you get when upgrading electron deps on master?

bj00rn commented 6 months ago

Please have a look at https://github.com/thomasnordquist/MQTT-Explorer/pull/757

nicklasb commented 6 months ago

@thomasnordquist , @bj00rn : Let me just say that is just GREAT! And yeah, collaboration can be hard, especially in open source, sometimes the giving and the taking doesn't add up at all.

bj00rn commented 5 months ago

@thomasnordquist Can you please have a look at master, It should be ready for a pre-release.

thomasnordquist commented 5 months ago

Thank you, I will work on it this week.

bj00rn commented 5 months ago

Thank you, I will work on it this week.

Give me a shout if something is broken.

Some notes:

https://github.com/thomasnordquist/MQTT-Explorer/blob/737afb3c1b9f58aa9ff639a0e91ed86d2cd2b5c9/app/src/components/Tree/TreeNode/TreeNodeTitle.tsx#L22 https://github.com/thomasnordquist/MQTT-Explorer/blob/737afb3c1b9f58aa9ff639a0e91ed86d2cd2b5c9/src/spec/demoVideo.ts#L87 https://github.com/thomasnordquist/MQTT-Explorer/blob/737afb3c1b9f58aa9ff639a0e91ed86d2cd2b5c9/src/spec/util/expandTopic.ts#L4