search

thomasnordquist / MQTT-Explorer

An all-round MQTT client that provides a structured topic overview
https://mqtt-explorer.com
Other
2.99k stars 287 forks source link

fix: use sparkplugb decoder only for spBv1.0 topic #793

Closed bj00rn closed 4 months ago

bj00rn commented 4 months ago

Dirty fix #792 by inspecting topic as suggested by https://github.com/thomasnordquist/MQTT-Explorer/issues/792#issuecomment-2111972106

Tested with sparkplug client https://github.com/eclipse/tahu/blob/master/javascript/examples/simple/example.js

The whole decoder choice logic should probably be cleaned up later on to support #493 and the likes. I guess decoding should not be done in backend in order to choose decoder interactively.. See #655

image

bj00rn commented 4 months ago

@thomasnordquist I'll merge this until we get decoding sorted properly in frontend.

thomasnordquist commented 4 months ago

I am almost done, still needs some testing and small fixes ☺️ The react state and decoder settings are not yet completely in sync (you select a decoder and it is only updated with the next message)

Björn Dalfors @.***> schrieb am So., 19. Mai 2024, 11:24:

@thomasnordquist https://github.com/thomasnordquist I'll merge this until we get decoding sorted properly in frontend.

— Reply to this email directly, view it on GitHub https://github.com/thomasnordquist/MQTT-Explorer/pull/793#issuecomment-2119167010, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB25FGOLTU7YIORPPV5WMSDZDBVWDAVCNFSM6AAAAABHYGBNTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGE3DOMBRGA . You are receiving this because you were mentioned.Message ID: @.***>

bj00rn commented 4 months ago

I am almost done, still needs some testing and small fixes ☺️ The react state and decoder settings are not yet completely in sync (you select a decoder and it is only updated with the next message) Björn Dalfors @.> schrieb am So., 19. Mai 2024, 11:24: … @thomasnordquist https://github.com/thomasnordquist I'll merge this until we get decoding sorted properly in frontend. — Reply to this email directly, view it on GitHub <#793 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB25FGOLTU7YIORPPV5WMSDZDBVWDAVCNFSM6AAAAABHYGBNTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGE3DOMBRGA . You are receiving this because you were mentioned.Message ID: @.>

Sweer, if you push something I can do some testing too