test.yml using wrong ref

thomasnordquist / MQTT-Explorer

An all-round MQTT client that provides a structured topic overview

https://mqtt-explorer.com

Other

2.99k stars 287 forks source link

test.yml using wrong ref #806

Closed bj00rn closed 4 months ago

bj00rn commented 4 months ago

I believe the current test.yml workflow is using the wrong ref to test PRs. The commit actually being tested in the workflow is base branch ref since the GITHUB_REF for pull_request_target PR base branch.

The correct syntax is as follows, to check out PR head sha.

 - uses: actions/checkout@v3
     with:
          ref: ${{ github.event.pull_request.head.sha }}
      - name: Rerun on comment