search

thomasonw / ATmegaxxM1-C1

Arduino IDE support files for CAN enabled Atmel AVR chips: ATmega64M1, ATmega32M1, ...
GNU Lesser General Public License v2.1
31 stars 18 forks source link

Add recipe.preproc.macros #1

Closed per1234 closed 8 years ago

per1234 commented 8 years ago

Copy preproc.macros.flags and recipe.preproc.macros from the Arduino AVR Boards 1.6.9 platform.txt. This solves the issue of the MCU specific macros not being correctly handled by the preprocessor. in Arduino IDE 1.6.6 and 1.6.7(https://github.com/arduino/Arduino/issues/4617). See https://github.com/arduino/arduino-builder/issues/106 for more information on the cause of this issue. Note that I did not copy preproc.includes.flags and recipe.preproc.includes as they are not relevant to arduino/Arduino#4617.

per1234 commented 8 years ago

I noticed that the default arduino-builder recipe.preproc.includes also doesn't have -mmcu but even if I test this PR with your test code moved to a library or an include from the sketch folder the MCU specific macro works fine. So I'm not sure if it's better to add preproc.includes.flags and recipe.preproc.includes to your platform.txt just to be safe or to keep this change as minimal as possible while still solving the issue as it is currently. Let me know if you want me to add that recipe also and I can squash to a single commit.

thomasonw commented 8 years ago

Thank you, confirmed this solved the issue.

thomasonw commented 8 years ago

@per1234 , On your question regarding "Let me know if you want me to add that recipe also and I can squash to a single commit" - I really have no way to judge, the details of the newer Arduino IDE is an area I am not fully fim with, I follow examples :-) So, can I leave it to you which way is the best?

I have tested the commit you pushed, and it does solve the direct issue. But if you think it is best to do more, please feel free to do so.

Thank you again for your time and the special effort of creating a commit for my porting effort.

-al-

thomasonw commented 8 years ago

@per1234 : Again, wish to thank you for taking the time to dig into my problem. At your coaching I went back and did a fil-com of my platform.txt and the master contained in Arduino IDE 1.6.7, noting a few more deltas. I have reved my copy to match the 'official' platform.txt from ide 1.6.7, and things work well now. Plus, I expect doing so will catch some other potential issues.

Thank you again for your assistance, and I am going to communicate this 'problem' back to my original source for my platform.txt that in hindsight appears was down-revved.

per1234 commented 8 years ago

Glad to have been able to make a small contribution to your project! I think especially your addition of the compiler.warning_flags lines is a big improvement, I had planned to submit another pull request for that.