Closed QuLogic closed 4 years ago
can I get you to test that this has been resolved by installing and checking the GitHub version?
Unfortunately not. Looking at the log, I just noticed this warning:
encode.cpp: In function 'int double2int(double)':
encode.cpp:18:33: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
18 | return reinterpret_cast<int&>(d);
| ^
and the line number indicates that the #if
was not taken.
It looks like you can check WORDS_BIGENDIAN
from the R header for this.
yeah - was just looking at the same... can you test again
OK, we're good now; works on x86_64 and s390x (didn't want to tie up other stuff). Thanks for the quick fix.
On s390x, trying to build farver 2.0.1, most (all?) tests that check colour encoding fail:
As s390x is a big-endian architecture, I think doing things like this won't work.