search

thomasp85 / fiery

A flexible and lightweight web server
https://fiery.data-imaginist.com
Other
240 stars 12 forks source link

Consider running on random port in tests #35

Closed gaborcsardi closed 5 years ago

gaborcsardi commented 6 years ago

Otherwise one cannot run multiple test suites in parallel. Or test suites for multiple versions of fiery, like we do in revdepcheck.

HenrikBengtsson commented 6 years ago

I second this, I almost always get:

✔ fiery 1.1.0                            ── E: 1     | W: 0     | N: 1

when testing in parallel. At times, there is a random delay such that the "old" and "new" tests on fiery do not clash, but it is more frequently a fail than a pass by chance. I need to manually rerun fiery in sequential mode by revdep_add(packages = "fiery") followed by revdep_check().

PS. There's more background on this in https://github.com/r-lib/revdepcheck/issues/95

HenrikBengtsson commented 5 years ago

Bumping. Pls.

HenrikBengtsson commented 5 years ago

Thanks for doing this - I can confirm that fiery now passes revdep checks just fine.