thomasp85 / fiery

A flexible and lightweight web server
https://fiery.data-imaginist.com
Other
240 stars 12 forks source link

lazy(...) => sequential(..., lazy = TRUE) #7

Closed HenrikBengtsson closed 7 years ago

HenrikBengtsson commented 7 years ago

FUTURES: Replaces lazy(...) with sequential(..., lazy = TRUE) because lazy() is deprecated in the future package; will soon be defunct, cf. Issue https://github.com/HenrikBengtsson/future/issues/109

Please validate that fiery still works as expected; I did the changes and ran R CMD check, ran the Fire example in the browser, but nothing more.

codecov-io commented 7 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         443    444    +1     
=====================================
+ Hits          443    444    +1
Impacted Files Coverage Δ
R/FutureStack.R 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 070cd3f...9528a66. Read the comment docs.

thomasp85 commented 7 years ago

Thanks... When do I need to release this the latest (that is, when do you expect lazy to be removed from the CRAN version)?

HenrikBengtsson commented 7 years ago

Thxs. I just released future 1.5.0 - in which I did want to defunct lazy() but forgot that your pkg and two of mine on CRAN so couldn't. I've fixed mine and plan to submit to CRAN so that lazy() can be made defunct in next release of future. So, maybe a month+ or so from now, if that works with you?