thomasp85 / ggforce

Accelerating ggplot2
https://ggforce.data-imaginist.com
Other
916 stars 106 forks source link

Replacing concaveman #308

Closed schochastics closed 9 months ago

schochastics commented 1 year ago

concaveman is just a suggested package, but it is quite heavy in terms of dependencies if it needs to be installed. There is potentially more lightweight option RcppConcaveman which wraps a C++ implementation of concaveman (unfortunatelly not on CRAN, but it seems quite easy to wrap the cpp code). It also comes with the added benefit of being more efficient.

thomasp85 commented 1 year ago

Oh, nice - we should def explore this

thomasp85 commented 9 months ago

hmmm... It appears that C++ port is severely bug-riddled as it misses points that ends up outside the hull, and makes up new points along the hull that was never there to begin with + it doesn't create the same result on multiple runs