search

thomasp85 / ggfx

Filters and Shaders for 'ggplot2'
https://ggfx.data-imaginist.com
Other
167 stars 4 forks source link

'color' doesn't work in with_outer_glow() #17

Open gkaramanis opened 3 years ago

gkaramanis commented 3 years ago

I have only tried this with with_outer_glow(): colour works, but not color 🙂

ggplot() +
  with_outer_glow(
    geom_point(aes(x = 0, y = 0), size = 10),
    color = "red",
    expand = 10
  )

Rplot

thomasp85 commented 3 years ago

ggfx is decidedly British 🙂

jan-glx commented 3 years ago

When you say "decidedly", is that British too? image (Or would you accept some hero's PR to bring color to us?)

thomasp85 commented 3 years ago

In the British sense, yes😄

No, I'll not accept a PR no matter how heroic, because it's sets a precedence for what a user can expect from naming and I would forever be required to add and support US and UK spelling in all functions.

Maintaining ggplot2 I can say that this is not fun