search

thomasp85 / ggraph

Grammar of Graph Graphics
https://ggraph.data-imaginist.com
Other
1.08k stars 116 forks source link

Revdep check failure with upcoming ggplot2 3.5.0 #354

Closed teunbrand closed 10 months ago

teunbrand commented 11 months ago

Hi Thomas,

As you know, a new version of ggplot2 is coming up. {ggraph} was in the list of packages with revdep failures. While investigating, I've isolated the cause to the following lines:

https://github.com/thomasp85/ggraph/blob/febab71076d7cf277cdb79b823f262b626651703/R/geom_edge_density.R#L147-L152

Where data is not (anymore) a vector but a <data.frame>. Should be fixable by using:

fill = alpha(data$edge_fill %||% data$fill %||% "darkgrey")

Cheers