deal with issues 2 and 3

m-clark commented 6 years ago

Howdy! I've been using this package quite a bit, and kept coming across the discrete scale issue (issue #2), so I thought I'd take a whack at it. I basically just did the same thing as scale_color/fill_viridis_d that's already part of ggplot. Not sure if that's the route you'd want to take, but it appears to work just fine. While I was at it, I figured I'd add the new palettes as well (issue #3). Some things to note:

new functions scale_colour_scico_d/scale_color_scico_d/scale_fill_scico_d
added acton, bamako etc. to palettes.rda
build passes R CMD check with 0 errors 0 warnings 0 messages
added testthat tests for both color and fill discrete
checked new code against goodpractice::gp()
checked that scico_palette_data/_show work with new palettes
did not update DESCRIPTION beyond the need to pass R CMD CHECK (e.g. still says 17 palettes)
used the new batlow (scientific rainbow) palette for the default discrete palette
added example to the ggplot2-scales man page for the discrete case

This is my first stab at a fork and pull for something that wasn't a project I was involved with from the beginning, so if there is anything in particular you need done differently just let me know and I can try and work it out. Thanks again for offering this, and all of your other useful packages. Hopefully this saves you a little effort.

thomasp85 commented 6 years ago

Thank you very much. Great work for a first PR. in the future you might consider splitting up PRs so they only tackle one issue each (when applicable). This is not a critique, but simply something to keep in mind for the next time🙂

tungttnguyen commented 5 years ago

Can you guys update the list of palettes available in the package now? Thank you all for your hard work!

library(scico)

scico_palette_show()

^{Created on 2018-10-14 by the reprex package (v0.2.1.9000)}

thomasp85 / scico

deal with issues 2 and 3 #4