thomasp85 / shinyFiles

A shiny extension for server side file access
196 stars 47 forks source link

Buttons don't work after package update #136

Closed AlexanderKononov closed 3 years ago

AlexanderKononov commented 4 years ago

Hi =) thanks for this package. it is very useful! After last update buttons just stop to react, at all. Within inner examples "shinyFiles Example()" it is not working too. I downgraded shinyFiles. It started to work again.

I work on Windows 10. Thanks=)

R version 3.6.0 (2019-04-26) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows >= 8 x64 (build 9200)

Matrix products: default

locale: [1] LC_COLLATE=English_United Kingdom.1252 LC_CTYPE=English_United Kingdom.1252 LC_MONETARY=English_United Kingdom.1252 [4] LC_NUMERIC=C LC_TIME=English_United Kingdom.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] shiny_1.4.0.2 shinyFiles_0.7.5

loaded via a namespace (and not attached): [1] Rcpp_1.0.4.6 crayon_1.3.4 digest_0.6.25 later_1.0.0 mime_0.9 R6_2.4.1 lifecycle_0.2.0 [8] xtable_1.8-4 jsonlite_1.6.1 magrittr_1.5 pillar_1.4.3 rlang_0.4.5 rstudioapi_0.11 fs_1.4.1
[15] promises_1.1.0 vctrs_0.2.4 ellipsis_0.3.0 tools_3.6.0 fastmap_1.0.1 httpuv_1.5.2 yaml_2.2.1
[22] compiler_3.6.0 pkgconfig_2.0.3 htmltools_0.4.0 tibble_3.0.1

vnijs commented 4 years ago

Can you provide some more information on what is (not) working exactly? Screenshots would be helpful.

vnijs commented 4 years ago

FYI I don't use Windows much everything seem to be running fine in my Windows VM. I'll need more information about the issue to help out.

image

AlexanderKononov commented 4 years ago

thanks. so. After updating, any buttons do not open any windows to file management. after clicks, the next messages appear in R console: input$file value:

[1] 0 attr(,"class") [1] "integer" "shinyActionButtonValue"

input$directory value:

[1] 0 attr(,"class") [1] "integer" "shinyActionButtonValue"

input$save value:

[1] 0 attr(,"class") [1] "integer" "shinyActionButtonValue"

input$file value:

[1] 1 attr(,"class") [1] "integer" "shinyActionButtonValue"

shinyFile_issue
vnijs commented 4 years ago

The messages in Rstudio look as expected and I cannot replicate the issue you are seeing. Can you open the example in Chrome ("Open in Browser) and report if there are any messages/errors you can see when you open chrome developer tools?

image

@rpodcast Is shinyFiles version 0.8.0 working as expected on your windows machines? Could use some help here to figure out what is going on.

jraniero commented 3 years ago

I am encountering the same issue. Simple example here does not throw any error, but when clicking the button, nothing happens (no directory window is shown):

library(shiny)
library(shinyFiles)
shinyApp(
  shinyUI(bootstrapPage(
    shinyDirButton("folder", "Select a folder", "Please select a folder", FALSE)
  )),

  shinyServer(function(input, output) {

    shinyDirChoose(input, "folder", roots=c(wd="."), filetypes=c("", "txt"))

    observe({
      print(input$folder)
    })
  })
)

You can check the video attached: [https://user-images.githubusercontent.com/20048866/126959766-12800432-2dc7-4014-8667-376edea5b8ad.mp4]

Here is my session info:

R version 3.5.1 (2018-07-02) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows Server >= 2012 x64 (build 9200)

Matrix products: default

locale: [1] LC_COLLATE=Dutch_Belgium.1252 LC_CTYPE=Dutch_Belgium.1252 LC_MONETARY=Dutch_Belgium.1252 [4] LC_NUMERIC=C LC_TIME=Dutch_Belgium.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] shinyFiles_0.9.0 shiny_1.6.0

loaded via a namespace (and not attached): [1] Rcpp_1.0.1 rstudioapi_0.13 magrittr_1.5 xtable_1.8-3 R6_2.4.0 rlang_0.4.11
[7] fastmap_1.1.0 tools_3.5.1 jquerylib_0.1.4 htmltools_0.5.1.1 ellipsis_0.3.2 yaml_2.2.0
[13] digest_0.6.27 tibble_2.1.1 lifecycle_1.0.0 crayon_1.3.4 later_1.2.0 sass_0.4.0
[19] promises_1.2.0.1 fs_1.5.0 rsconnect_0.8.13 cachem_1.0.5 mime_0.6 compiler_3.5.1
[25] bslib_0.2.5.1 pillar_1.4.2 jsonlite_1.7.2 httpuv_1.6.1 pkgconfig_2.0.2

vnijs commented 3 years ago

Closing. Pushing new version to CRAN soon. If the below does not work, with the current development version, please re-open this issue.

shinyFiles::shinyFilesExample()