thomasp85 / tidygraph

A tidy API for graph manipulation
https://tidygraph.data-imaginist.com
Other
546 stars 61 forks source link

Add argument name to pull for dplyr 1.0.0 #123

Closed llrs closed 4 years ago

llrs commented 4 years ago

This adds the new name argument of pull to the tidygraph. So that it works with the new dplyr 1.0.0.

I was trying to implement this in another package and looking for examples I found you didn't have implemented. I think I figured it out how does it work, but let me know if there is a better way to do this.

thomasp85 commented 4 years ago

The omission is intentional as I don't want to take on a dependency on dplyr 1.0

The use of ellipsis allows you to forward the name argument if the user provides it so tidygraph already supports it implicitly