thomasp85 / tidygraph

A tidy API for graph manipulation
https://tidygraph.data-imaginist.com
Other
543 stars 61 forks source link

Removing nobigint from the betweeness calculations. #163

Closed jdfoote closed 1 year ago

jdfoote commented 1 year ago

As far as I can tell, this is the only place that the deprecated nobigint parameter is mentioned, and I removed it from both the betweenness and estimate_betweenness function calls, as well as tidygraph's centrality_betweenness() function.

tripartio commented 1 year ago

As of tidygraph 1.2.2 (CRAN), this warning still displays. Is there any progress on this pull request?

tripartio commented 1 year ago

Also, @jdfoote, is there a reason that you changed 'cutoff = NULL' to 'cutoff = -1' in line 82?

jdfoote commented 1 year ago

The default for cutoff changed to -1 (https://igraph.org/r/doc/betweenness.html)

thomasp85 commented 1 year ago

thanks