thomasp85 / tidygraph

A tidy API for graph manipulation
https://tidygraph.data-imaginist.com
Other
547 stars 62 forks source link

add test case for bind_graph on lists + implement fix #200

Open pearsonca opened 1 month ago

pearsonca commented 1 month ago

As documented, bind_graph indicates it supports passing a list of objects as .data.

However, the current implementation does not support that use case; see #187

This code introduces a test (which the current main code fails) + a fix to provide the documented behavior of bind_graph (which is definitely worth having, and the extant code suggests is actually contemplated).

Alternatives considered: an unfocus.list method. That seems potentially reasonable, and perhaps useful for other areas of the code I didn't examine, but would also require some careful checking of method dispatch. I went with this approach as more surgical.