thomaspark / bootswatch

Themes for Bootstrap
https://bootswatch.com
MIT License
14.57k stars 3.67k forks source link

Flatly bs-table-accent-bg is overriding other colours #1110

Closed Barbara-358 closed 3 years ago

Barbara-358 commented 3 years ago

Hi,

The setting for the table class's bs-table-accent-bg is now seemingly overriding other colouring settings.

In https://bootswatch.com/5/flatly/bootstrap.min.css:

 .table {
    --bs-table-bg: transparent;
    --bs-table-accent-bg:#ecf0f1;
    [...]
}

This colours the entire table in #ecf0f1. image

I've had this same HTML code for months now, but suddenly, unless I include an override in the <header> like this, my table is coloured all blue:

.table {
    --bs-table-accent-bg: transparent!important;
  }

This is my html:

<table class="table table-hover shadow-sm table-bordered border-info">
    <thead class="table-info"> [...] </thead>
    <tbody> [...] </tbody>
</table>

This is what it used to look like/looks like if I override bs-table-accent-bg: image

What's changed?

Barbara-358 commented 3 years ago

looking at the commit log for the latest update, seems it used to be set to transparent but not anymore: image image

thomaspark commented 3 years ago

Hey @Barbara-358, thanks for the bug report. Will take a look...

ghost commented 3 years ago

Hey, I have the same problem: Since a few days the background colors I set on table cells are getting ignored/overwritten. I just tested it with some themes and it still doesn't seem to work with darkly and sketchy for example (cyborg, journal, minty and morph are working fine though).

Barbara-358 commented 3 years ago

Hey @thomaspark , the download from the website (https://bootswatch.com/5/flatly/bootstrap.min.css) still has the --bs-table-accent-bg:#ecf0f1; CSS. When will that be updated? Thanks, be well.

thomaspark commented 3 years ago

Hey @Barbara-358, we'll have to wait till the next Bootstrap version to do a release and update the site, but you can grab the latest from the v5 branch in the meantime.