search

thomaspark / bootswatch

Themes for Bootstrap
https://bootswatch.com
MIT License
14.58k stars 3.67k forks source link

Differences between Bootswatch.com and code/dist #1259

Open mybooc opened 1 year ago

mybooc commented 1 year ago

When I tried to reproduce the vapor theme page of the Bootswatch site, there are some differences.

Example1: The color of the top navbar nav-items is 'light blue' on the Bootswatch site and 'white' with the github vapor/bootstrap.css file.

Example2: The black text in the second (light background) navbar is sharp on the Bootswatch site and slightly blurred with the github vapor/bootstrap.css file.

Comparing the bootstrap.css used by the Bootswatch site and the file on github showed some differences, also for other themes.

Although these changes make the themes look better (personal opinion), I prefer to see the themes on Bootswatch.com with the current dist github files, or, maybe some explanation why and what are the changes.

Anyway, thank you for Bootswatch!

Update: Think I understand now. code/dist is current release. The latest and the greatest can be downloaded via bootswatch.com per theme dropdown.

thomaspark commented 1 year ago

Hi @mybooc, the site displays the latest release per https://github.com/thomaspark/bootswatch/tags.

The latest version on the v5 includes additional changes that will be rolled into a future release.

mybooc commented 1 year ago

Thank you for this, is clear now.

Overrided commented 1 year ago

@thomaspark hi! I still can observe some differences between latest (v5.3.1) bootswatch themes and original dist from bootstrap of same version.

For example, h3 header font size in bootswatch darkly master branch: https://github.com/thomaspark/bootswatch/blob/c7d7f8439fe949e506e6d2e15b4a930036077241/dist/darkly/bootstrap.css#L248C1-L248C10

h3 header font size in bootswatch darkly v5 branch: https://github.com/thomaspark/bootswatch/blob/d3c27c4f4b582f83f1e415d79dd63e8d95ae4c75/dist/darkly/bootstrap.css#L248

While in bootstrap: https://github.com/twbs/bootstrap/blob/913efd78c63990eecf27a4b755b4221a266ff3b0/dist/css/bootstrap.css#L240C10-L240C10

I can also see some difference in nav-item styles. I guess it's some kind of variables in a theme template that differ? Is it by design or is it a bug?)

Thanks for your work! Best wishes)