thomaspark / bootswatch

Themes for Bootstrap
https://bootswatch.com
MIT License
14.56k stars 3.67k forks source link

Make table inherit body's color #1310

Closed bblanchon closed 2 months ago

bblanchon commented 3 months ago

When trying to fix #1308, I quickly realized that hardcoding the values $table-color doesn't work great for dark color mode.

The best solution I found was to reset the value of $table-color like so:

$table-color: initial !default;

The effect of this is that the table inherits the color of the body, which works well for all themes in both light and dark modes.

thomaspark commented 3 months ago

Thanks for the PR. This seems on the right path, but there is some inconsistency with font color when a class like .table-primary is applied.

For example, Pulse before:

Screenshot 2024-08-04 at 11 42 01 AM

Pulse after:

Screenshot 2024-08-04 at 11 41 57 AM

And for reference, Pulse v4:

Screenshot 2024-08-04 at 11 42 51 AM

bblanchon commented 2 months ago

I amended my previous commit. Here is the new Pulse:

image

I updated all the other themes too.

thomaspark commented 2 months ago

Looks good, thank you!