thomaspark / bootswatch

Themes for Bootstrap
https://bootswatch.com
MIT License
14.57k stars 3.67k forks source link

Support for Bootstrap 4 #499

Closed travisdahlke closed 7 years ago

travisdahlke commented 9 years ago

With the release of Bootstrap 4 alpha, when can we expect the bootswatch themes to be updated? I know it probably makes sense to wait for a beta before spending too much time on it.

garymoon commented 7 years ago

Jeez, there needs to be a :O reaction. Amazing.

thomaspark commented 7 years ago

Hey @TheCoder4eu, thanks for the heads up. Figures b2 would come out as I was in the midst of updating to b1. 😛

Actually the work to go from b1 to b2 should be much less than a6 to b1. I'm pretty far along — have the preview pages done and going through the themes now. Hoping to have b2 done by this Monday.

@jipexu, I'll push what I have soon and take a look at your branch to see how we can merge our work together. One change I've made is the approach for _variables.scss to only include the variables that have been modified. This should cut down on maintenance work as each version of the variables file changes things up.

AmirSavand commented 7 years ago

@thomaspark Can't wait to create some themes for our blogging platform (gonevis.com).

BTW people, +1 seems like a useless comment but actually, some developers say it keeps them motivated.

robcresswell commented 7 years ago

@AmirSavand I've not heard that. Many projects explicitly ask you to use GH reactions like thumbs up to avoid email spam. If we all sent in +1s they'd have a constant stream of useless emails :)

AmirSavand commented 7 years ago

@robcresswell I totally agree, I never heard till I've read about it on reddit.

jipexu commented 7 years ago

@thomaspark yes i am sure you will find better approch for the variable ...mine was a little be cahotic ... and i dont know enough the theme to see all the small rendering mistake ... because sometimes i (we) used the gray scale as a other color scale .... so is not always easy to maintain so no prob take what you need or only use as base ... i done just to have something that work quickly ... and it was a good exercice to play scss with koala !

TheCoder4eu commented 7 years ago

@thomaspark , yes, in the blog post they admit the delta between alpha6 and beta was brutal, and they promise changes between betas/final will not have the same impact.

TheCoder4eu commented 7 years ago

Btw @thomaspark thanks for the big effort you are doing to support v4!!!!

thomaspark commented 7 years ago

OK, I might have been optimistic about getting it all done today, but making good progress. Just pushed what I have to the v4 branch.

Updated themes include cerulean, cosmo, cyborg, darkly, flatly, journal, litera, materia, and yeti. The rest will be coming soon!

robcresswell commented 7 years ago

@thomaspark If you want to open issues for each missing theme, I'm sure we could divide up the work and take them on. I've got time to help out, and I've been using Bootstrap / Bootswatch for years; please don't feel you have to do all the work by yourself.

robcresswell commented 7 years ago

@utopianknight Comments like that are incredibly unhelpful. For a start, I'm fairly sure the "Paper" theme is identical to "Materia", and if not, just leaving a +1 with "do some free work for me" is a terrible attitude.

paulbhartzog commented 7 years ago

Just wanted to say thx to anyone who helps out on this. :-)

thomaspark commented 7 years ago

Hey all, thanks for the support!

@robcresswell, I'll be ok updating the themes myself, but help with markup on the index.html pages would be welcome. Issues like #698 and updating any markup I've missed to v4, or better yet, a grunt task that rebuilds all of the preview pages from template using something like grunt-html-build and the metadata in /api/4.json.

nickserv commented 7 years ago

Sweet, can we please get 4.0.0-beta.2 published on npm? It seems to be tagged in the repo but not on npm.

thomaspark commented 7 years ago

@nickmccurdy, done! https://www.npmjs.com/package/bootswatch

nickserv commented 7 years ago

Awesome, thanks! I'm looking forward to testing this out for a production site.

Is it intentional that the theme directories are now in a dist folder instead of the top level folder?

thomaspark commented 7 years ago

Yup there was a bit of a reorg for the repo, dist for the themes, docs for the site, so they don't get mixed up with all the meta files.

nickserv commented 7 years ago

Nevermind I noticed that upstream now does that too, so it makes sense to keep it consistent. 😄

YoungZeeZee commented 7 years ago

Hi All,

I am very new at Bootstrap/bootswatch and do not have any background knowledge about things. My website collapsed on Saturday later noticed that the "min.css" got an extra "4" in the link. Now it works better but some features are still not working. i.e: dropdown menus from bootswatch. It does nothing and have a problem with "Basic Collapsible" feature, "bootstrap.min.js" is not working well with bootswatch. Could you please tell me what happened and what can i do now?

Thank you in advance for your help. Regards, ZeeZee

thomaspark commented 7 years ago

Hey @YoungZeeZee, if you haven't changed anything on your site yet, you should stick with version 3. You would just need to change your theme's url to add a 3 instead of 4. So something like https://bootswatch.com/3/flatly/bootstrap.min.css.

Better yet, go with this url as it's meant to be used this way: https://maxcdn.bootstrapcdn.com/bootswatch/3.3.7/flatly/bootstrap.min.css

YoungZeeZee commented 7 years ago

Hi @thomaspark ,

Thank you for your quick response. I have changed "4" to "3" and it works :) When i started using bootswatch i found/added the link without any number so it was "https://bootswatch.com/superhero/bootstrap.min.css".

Thank you again.

Kind regards, Young ZeeZee

YoungZeeZee commented 7 years ago

My comment has been edited by me. All clear now. Regards, Zoltan

jipexu commented 7 years ago

you seems to have a probleme with js ...

lightdot commented 7 years ago

@YoungZeeZee, do not hotlink directly to repository files, this is a bad practice. As suggested, use a CDN: https://maxcdn.bootstrapcdn.com/bootswatch/3.3.7/superhero/bootstrap.min.css or download the files to the server where your web page is hosted and link them locally. Same goes for .js files.

TheCoder4eu commented 6 years ago

Hi @thomaspark , I just noticed that beta3 is out!

In the Blog post: https://blog.getbootstrap.com/2017/12/28/bootstrap-4-beta-3/

they say it is the last release before Final! Kind Regards!

thomaspark commented 6 years ago

Hey @TheCoder4eu, update for v4-beta.3 was just pushed in #765!

TheCoder4eu commented 6 years ago

@thomaspark Great! thank you!!!