search

thomaspark / bootswatch

Themes for Bootstrap
https://bootswatch.com
MIT License
14.57k stars 3.67k forks source link

Sketchy theme issue with Check Boxes and Radio Buttons Inline #946

Closed GaryG54 closed 4 years ago

GaryG54 commented 4 years ago

When I setup simple check boxes or radio buttons with the sketchy theme and use inline setting, the check/radio buttons are skewed from the item "labels" on all devices. This does not happen with any of the other themes. I just updated to 4.4.1 of all the themes, and the problem persists only in theme sketchy.

thomaspark commented 4 years ago

Can you post the markup you're using, either here or on JSBin/JSFiddle?

GaryG54 commented 4 years ago

Thomas,

I'm generating the project using AppStudio 8.0.4, of which George just updated to the latest Bootswatch. Here is an example of a simple app with sketchy for check box and radio button.

https://www.theweedwerx.com/Project21b/index.html

This app works with all other themes.

Gary

On Wed, Feb 12, 2020 at 3:08 PM Thomas Park notifications@github.com wrote:

Can you post the markup you're using, either here or on JSBin/JSFiddle?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thomaspark/bootswatch/issues/946?email_source=notifications&email_token=AORH3JVO57I7LD3KYW5BYM3RCRJKNA5CNFSM4KT5WV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELSGQ3A#issuecomment-585394284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AORH3JRICTRHYFFWMP2C3XTRCRJKNANCNFSM4KT5WV5A .

thomaspark commented 4 years ago

Great, pushing a fix for this now.

GaryG54 commented 4 years ago

Thomas,

Looks good. Thanks. Keep up the good work. :)

Gary

On Thu, Feb 13, 2020 at 5:24 PM Thomas Park notifications@github.com wrote:

Great, pushing a fix for this now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thomaspark/bootswatch/issues/946?email_source=notifications&email_token=AORH3JV2HBEZOQNSYK5I4PLRCXCCHA5CNFSM4KT5WV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELW23GI#issuecomment-586001817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AORH3JRGEEIIYRFPPIAFLY3RCXCCHANCNFSM4KT5WV5A .

GaryG54 commented 4 years ago

Thomas,

You didn't change the version number on the new sketchy. George noticed it. Are you going to change the version #, or is this not worth the trouble?

Thanks

Gary

On Thu, Feb 13, 2020 at 5:24 PM Thomas Park notifications@github.com wrote:

Great, pushing a fix for this now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thomaspark/bootswatch/issues/946?email_source=notifications&email_token=AORH3JV2HBEZOQNSYK5I4PLRCXCCHA5CNFSM4KT5WV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELW23GI#issuecomment-586001817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AORH3JRGEEIIYRFPPIAFLY3RCXCCHANCNFSM4KT5WV5A .

thomaspark commented 4 years ago

The version number will be bumped with Bootstrap's next release.

GaryG54 commented 4 years ago

I just noticed it is in sync with Bootstrap. May I suggest you add something to the versioning header that shows it's updated. Just a suggestion. May help you track down issues easier in the future.

On Fri, Feb 14, 2020 at 10:05 AM Thomas Park notifications@github.com wrote:

The version number will be bumped with Bootstrap's next release.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/thomaspark/bootswatch/issues/946?email_source=notifications&email_token=AORH3JQJT34DPIPBAGCRZJLRC2XLRA5CNFSM4KT5WV5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZKFJQ#issuecomment-586326694, or unsubscribe https://github.com/notifications/unsubscribe-auth/AORH3JXNEB5Q54OCXO3RIETRC2XLRANCNFSM4KT5WV5A .