search

thomaspark / gridgarden

A game for learning CSS grid layout đŸ¥•
https://cssgridgarden.com
MIT License
3.21k stars 305 forks source link

Corrected: Hungarian translation #139

Closed kzsa closed 3 years ago

kzsa commented 3 years ago

e.g: Level 12. "Az egyik dolog ami miatt a CSS grid jobb, mint a flexbox..." means: "One of the things that makes the CSS grid better than the flexbox ..." Level 26. mistake fixed Additional minor translational and grammatical improvements.

(Flexbox is a one-dimensional thing, a "vector" / a row or a column, where you can justify the content in vector direction say "inline/writing direction/rtl/ltr..." and align the items in block dimension say "perpendicular to the vector". The css grid is a two dimensional grid system. Both are designed to solve different problems. I think, neither is better than the other. - Zsolt)

"So there is your choice. Do you want to let your content control the way it is displayed, on a row by row or column by column basis? That's flexbox. Or, do you want to define a grid, and either allow items to be auto-placed into the cells defined by that grid, or control their positioning using line-based positioning or grid template areas. That’s the grid. - Rachel Andrew"

thomaspark commented 3 years ago

Hey @kzsa, thanks for the improvements. Looks like there's some whitespace changes throughout the file. Can you revert those and keep just the translation edits for the PR? Are the changes only to level 12 and 26?

kzsa commented 3 years ago

Hi, I retranslated from #1 to Win everything. The whole Hungarian part of level.js. I'll review it right away. Sorry! Br.

Thomas Park notifications@github.com ezt Ă­rta (idÅ‘pont: 2021. febr. 16., K, 23:43):

Hey @kzsa https://github.com/kzsa, thanks for the improvements. Looks like there's some whitespace changes throughout the file. Can you revert those and keep just the translation edits for the PR? Are the changes only to level 12 and 26?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thomaspark/gridgarden/pull/139#issuecomment-780165048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODJG7EU3HSNUQA2UU2PA5TS7LYH3ANCNFSM4XS4GNLQ .