Adding radio buttons for width options (text block), resolves #181

thomaspark / snowball

A WordPress plugin for making immersive longform articles

https://snowball.openhtml.org/

GNU General Public License v2.0

90 stars 24 forks source link

Closed sukritchhabra closed 8 years ago

sukritchhabra commented 8 years ago

Adding Radio buttons as width options
The 3 options now are Full Width, Fluid and Fixed
Was unsure how to scope them or whether to make them global, therefore scoping them to .snowbal-block-text. (We can change this if needed)

sukritchhabra commented 8 years ago

@thomaspark I just realized this hadn't been merged. Could you take a look at this and let me know if something needs to be changed? Thanks :)

thomaspark commented 8 years ago

Hey @sukritchhabra, this looks good (still have to test) but can you exclude the changes to all the min files in the pull request?

sukritchhabra commented 8 years ago

Hey @thomaspark, gotcha! Just removed all the minified files.

thomaspark commented 8 years ago

I tested it out and it's looking good. Could you make a few tweaks?

Rename from "Full Width" to "Full" to be consistent with the other values.
Reorder as Fixed > Fluid > Full, with Fixed as the default.
The .snowball-block-text.fixed-width style can be removed, since the default style of blocks is already a fixed 600px.
Move .fluid-width style to snowball.css/ snowball.min.css. Makes sense to put it alongside .full-width and .mid-width, and this also allows the full width media queries to kick in for mobile.

Let me know if you have any questions or thoughts about these suggestions. Thanks!

sukritchhabra commented 8 years ago

Hey @thomaspark, just made the changes you mentioned. Let me know if you think something else needs to be changed :)

thomaspark commented 8 years ago

Perfect, thanks Sukrit! This feature will be included in the next release.

sukritchhabra commented 8 years ago

Awesome :)