search

thomaspasser / gpio-buttons

Control volumio2 on RPi with GPIO buttons
http://tomatpasser.dk/gpio-buttons.zip
52 stars 19 forks source link

up-to-date plugin info #26

Closed macmpi closed 7 years ago

macmpi commented 7 years ago

Would be nice if gpio-plugin info is kept up-to-date in master Volumio plugin view (versioning, description, etc). You may want to routinely push PRs there to keep it current.

thomaspasser commented 7 years ago

Didn't know where to push it, thanks! Maybe it can be done automatically somehow, will think about that.

macmpi commented 7 years ago

GPIO Plugin is listed within system_controller category in that Repo, whereas package.json defines it as miscelleanea. You may want to line-up the 2 definitions by either changing category in package.json or in the repository.

thomaspasser commented 7 years ago

Changed the definition to system_controller (29c424f) and made a pull request: https://github.com/volumio/volumio-plugins/pull/75

macmpi commented 7 years ago

With that category change we may need to update install.sh older config.json compatibility tweak, as new file will be in new location: need to add mv to right location after seds probably. Can't do it right now, as I'm not in front of my Pi for few days to test: can you do it?

thomaspasser commented 7 years ago

You are absolutely right. Yes, I figure it is best if the script moves the file over if it exists in the old directory. Then edit it afterwards with the new naming convention. I'll get right to it.

thomaspasser commented 7 years ago

Fixed: f1420d8