add lint step to CI - Githubissues

thomaspoignant / api-scenario

API-scenario is a command-line tool that allows you to execute easily a scenario to test your APIs.

https://github.com/thomaspoignant/api-scenario#api-scenario

The Unlicense

16 stars 3 forks source link

add lint step to CI #36

Closed aftouh closed 4 years ago

aftouh commented 4 years ago

Issue #22

Add golangci-lint configuration file in .golangci.yaml
Fix identified lint issues
Use CI travis var in makefile for conditional steps
Added travis lint step. Can't launch a build! Hope still works after modification. 🤞
Install golangci-lint locally: brew install golangci/tap/golangci-lint

thomaspoignant commented 4 years ago

It seems there is still an issue with the CI. I have tried to run locally

make clean-all && make update-dependencies && make generate && make coverage CI=true

And it seems that it failed because go get modify go.mod and go.sum files. I think we should keep theses go get inside travis to avoid that.

What do you think about that @aftouh ?

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

aftouh commented 4 years ago

@thomaspoignant I fixed this issue by adding GO111MODULE=off before go get to add lib outside the project and avoir updating go.mod files. So the build works but the coverage have decreased.

The purpose of adding this step to makefile is to have a travis file with only make somthing steps and have all "logic" in one place. What do you thing ?

thomaspoignant commented 4 years ago

The purpose of adding this step to makefile is to have a travis file with only make somthing steps and have all "logic" in one place. What do you thing ?

SGTM 👌 About the decrease of the coverage, I think this is because you are testing some errors and we have no test for that, but that's fine for me, we should take care of this is another PR.