(bug) Tracing only initializes when specifying endpoint through config

thomaspoignant / go-feature-flag

GO Feature Flag is a simple, complete and lightweight self-hosted feature flag solution 100% Open Source. 🎛️

https://gofeatureflag.org/

MIT License

1.49k stars 148 forks source link

(bug) Tracing only initializes when specifying endpoint through config #2578

Closed hairyhenderson closed 2 weeks ago

hairyhenderson commented 3 weeks ago

Observed behaviour

After #2482 and #2485, tracing won't initialize unless the openTelemetryOtlpEndpoint config entry is set. When I'm using OTEL_EXPORTER_OTLP_ENDPOINT instead I'd rather not have to specify it in the configuration as well.

Expected Behavior

Tracing should be disabled via OTEL_SDK_DISABLED=true, otherwise it should be enabled by default.

Steps to reproduce

No response

hairyhenderson commented 3 weeks ago

/assign-me

github-actions[bot] commented 3 weeks ago

👋 Hey @hairyhenderson, this issue is already assigned to @thomaspoignant.

⚠️ It will become unassigned if it isn't closed within 10 days.

🔧 A maintainer can also add you to the list of assignees or swap you with the current assignee.

hairyhenderson commented 3 weeks ago

Well I tried - either way I'm going to take this on, it's a simple fix 😉

hairyhenderson commented 3 weeks ago

https://github.com/thomaspoignant/go-feature-flag/pull/2579 should solve this 🙂