search

thomaspoignant / go-feature-flag

GO Feature Flag is a simple, complete and lightweight self-hosted feature flag solution 100% Open Source. 🎛️
https://gofeatureflag.org/
MIT License
1.49k stars 148 forks source link

feat: Added Microsoft Teams Notifier #2636

Closed martinvibes closed 2 weeks ago

martinvibes commented 2 weeks ago

Description

Closes issue(s)

Checklist

netlify[bot] commented 2 weeks ago

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
Latest commit fa14bd1f6664b0e1140e0cb4b84dbac7402fc344
Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/672e2683aea3d800082c15e5
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.00%. Comparing base (1ddb559) to head (fa14bd1). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
notifier/microsoftteamsnotifier/notifier.go 81.25% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2636 +/- ## ========================================== + Coverage 84.96% 85.00% +0.04% ========================================== Files 102 103 +1 Lines 4721 4763 +42 ========================================== + Hits 4011 4049 +38 - Misses 564 566 +2 - Partials 146 148 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

martinvibes commented 2 weeks ago

hello @thomaspoignant kindly review :) @thomaspoignant

thomaspoignant commented 2 weeks ago

hello @thomaspoignant kindly review :) @thomaspoignant

I still see changes in the contributing.md any reason why?

martinvibes commented 2 weeks ago

@thomaspoignant i didn't touch the file

thomaspoignant commented 2 weeks ago

@thomaspoignant i didn't touch the file

Changes seems to come from you merge in this commit https://github.com/thomaspoignant/go-feature-flag/pull/2636/commits/705897702677703ab494fdcec1f58ff2f2b5da5d

BTW why did you merge the branch from @abdegenius and not the one from this repo? This is probably the reason why you have the issue.

martinvibes commented 2 weeks ago

hey @thomaspoignant i have fix the issues please check

my vscode was auto formatting on save

martinvibes commented 2 weeks ago

hello @thomaspoignant kindly review :)

martinvibes commented 2 weeks ago

hello @thomaspoignant any update

thomaspoignant commented 2 weeks ago

hello @thomaspoignant any update

I will do some clean up and merge the PR.

martinvibes commented 2 weeks ago

alright sir anticipating :)

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud