search

thomaspoignant / go-feature-flag

GO Feature Flag is a simple, complete and lightweight self-hosted feature flag solution 100% Open Source. 🎛️
https://gofeatureflag.org/
MIT License
1.45k stars 140 forks source link

(bug) The latest version of java OpenFeature provider doesn't support relay proxy version v1.3.0+ #582

Closed Yaroslav-Kovalchyk-Imprivata closed 1 year ago

Yaroslav-Kovalchyk-Imprivata commented 1 year ago

Observed behavior

dev.openfeature.contrib.providers.gofeatureflag.GoFeatureFlagProvider fails to parse "cacheable" attribute of relay proxy response. This flag is added in v1.3.0 into VariationResult structure. Used SDK and providers versions: 'dev.openfeature:sdk:1.3.0' 'dev.openfeature.contrib.providers:go-feature-flag:0.2.3'

Expected Behavior

New providers version that is able to parse the latest relay proxy response is available.

Steps to reproduce

No response

toddbaert commented 1 year ago

@thomaspoignant is this something that needs to be implemented in the GoFF provider in contribs?

thomaspoignant commented 1 year ago

@Yaroslav-Kovalchyk-Imprivata I have open a pull request to fix this issue in this PR https://github.com/open-feature/java-sdk-contrib/pull/246.

@toddbaert Yes it has to be fixed in the contrib repo, if you can have a look at the PR it would be awesome. I am also working on some integration tests to fail if I try to release a new version of the relay proxy that will not work with the providers.

toddbaert commented 1 year ago

@thomaspoignant merged and released. The new version should be available on maven central in 1h or so.

thomaspoignant commented 1 year ago

Awesome @toddbaert, thanks a lot for the fast review and release 🙏

@@Yaroslav-Kovalchyk-Imprivata you will be able to use the latest version of the relay proxy with this new version of the provider.

Yaroslav-Kovalchyk-Imprivata commented 1 year ago

Thank you, @thomaspoignant, for a quick fix!