search

thomasrolinger / chapel

a Productive Parallel Programming Language
https://chapel-lang.org
Other
0 stars 1 forks source link

Task: Refactor code #6

Closed thomasrolinger closed 2 years ago

thomasrolinger commented 2 years ago

Moving forward, it will be nice to split up our various functions into different files. It'll make it easier to maintain and add to.

I am thinking one file for normalization-related functions, one for pre-folding and one for post-resolution. And perhaps one for utilities.

I'm not sure if this is generally discouraged in regards to Chapel, but it would help us out while we are doing this research.

thomasrolinger commented 2 years ago

Addressed: https://github.com/thomasrolinger/chapel/commit/ac146b3a7671af95e4ae3fd805f78d0669888c9a

Decided against doing a big overhaul. It would be fairly complicated to split things up, as we have some global vectors that we use across passes, and we also rely on static functions in forallOptimizations.cpp that we didn't write.