search

thomassidor / tinytricks

Tiny Tricks - Modules for VCV Rack
Other
26 stars 7 forks source link

Fix some scope / Framebuffer problems #17

Closed baconpaul closed 4 years ago

baconpaul commented 4 years ago

The wave oscillator polyphony now works. Some occasional crashes emerged from the scope for a couple of reasons. First I added a few defensive null checks, but far more importantly, I used the FramebufferWidget more in the way it was intended, namely including an OpaqueWidget which dirties the parent appropriately. Some of the log messages about the FBW having size (nan,nan) and definitely the occasional crashes in exit in a widget destructor were caused by the prior pattern, I think.

Anyway with this change it all seems super stable to me. Best!

thomassidor commented 4 years ago

Ah, that makes sense. Was using it that way previously with several mini-scopes in it, but changed that for better performance during the refactoring.

I'll merge it in now, do some final testing and then hopefully get it out during today.

Thanks for the effort :)

thomassidor commented 4 years ago

Ok, everything have been pulled to master and I've requested an update in the VCV Plugin Library.

Thank you so much for helping with this! :)

baconpaul commented 4 years ago

Hey happy to help! Tag me on an issue if anything else pops up!