Dispatch an event when subtitles are updated in subtitle div.

thomassturm / VideoSub

HTML5 Video with SRT Subtitles

Other

120 stars 56 forks source link

Closed alexismo closed 10 years ago

alexismo commented 10 years ago

These 3 commits (2 code commits) resolve issues #8 and #9 by:

Reducing the draw calls to the DOM by only changing the contents of the subtitle div when the text of the subtitle should change (rather than every tick)
Dispatching a 'subtitlechanged' event to the DOM with information about the <video> tag, timecode and subtitle.

alexismo commented 10 years ago

It made no sense to suggest 2 features in 1 pull request. Changing it now.