search

thomasvargiu / RabbitMqModule

PHP implementation of AMQP protocol
15 stars 9 forks source link

Lazy connections #2

Closed krzysztof-gzocha closed 8 years ago

krzysztof-gzocha commented 8 years ago

@thomasvargiu Tests are failing for me even on master branch. Should I do something not specified in README in order to fix it?

thomasvargiu commented 8 years ago

@krzysztof-gzocha Sorry, I can't merge this. You are using another logic to implement another connection type. If you want to add the AMQPLazyConnection you should create a factory RabbitMqModule\Service\Connection\LazyConnectionFactory. Then you can add it on RabbitMqModule\Service\ConnectionFactory::$factoryMap:

    /**
     * @var array
     */
    protected $factoryMap = [
        'stream' => 'RabbitMqModule\\Service\\Connection\\StreamConnectionFactory',
        'socket' => 'RabbitMqModule\\Service\\Connection\\SocketConnectionFactory',
        'ssl' => 'RabbitMqModule\\Service\\Connection\\SSLConnectionFactory',
        'lazy' => 'RabbitMqModule\\Service\\Connection\\LazyConnectionFactory',
    ];
krzysztof-gzocha commented 8 years ago

Good point. Will fix it and open it in another PR

thomasvargiu commented 8 years ago

@krzysztof-gzocha Sorry, I re-open this pull request, it's ok here.

krzysztof-gzocha commented 8 years ago

Great, but there is still problem with tests.. Do you have any idea what might be wrong?

thomasvargiu commented 8 years ago

I need to check. But probably it's a dependency compatibility problem.

krzysztof-gzocha commented 8 years ago

Ok, @thomasvargiu. Let me know if there is anything more that I can do with this PR.

krzysztof-gzocha commented 8 years ago

@thomasvargiu any update in this topic?

thomasvargiu commented 8 years ago

@krzysztof-gzocha Can you rebase it with the master branch? I've fixed the tests. It was a problem with some E_USER_DEPRECATION triggered in zend-mvc.

krzysztof-gzocha commented 8 years ago

Ok. Thank you for information.

krzysztof-gzocha commented 8 years ago

@thomasvargiu done. Tests are passing again. Good job!

thomasvargiu commented 8 years ago

@krzysztof-gzocha Merged! Thank you!