search

thomasvrussell / sfft

Saccadic Fast Fourier Transform (SFFT) algorithm for Image subtraction in Fourier space
MIT License
50 stars 9 forks source link

Remove Skimage assertion #6

Open Astro-Sean opened 2 months ago

Astro-Sean commented 2 months ago

When running Easy_SparsePacket.ESP - there is an assert error that limits the version of scikit-image to - parse_version('0.16.1') <= skimage_version <= parse_version('0.18.3')

Is this necessary? - as the code seems to work find with the latest version of scikit-image

Using outdated version conflicts with the latest photutils packages

thomasvrussell commented 2 months ago

Hi @Astro-Sean, it can indeed work with lastest version of scikit-image. The consideration for this version constrain is due to the fact that SFFT used a function for Hough transform in Scikit-image, while the underlying algorithm seems has been updated after Scikit-image 0.18.3. I tested the new function but found sometimes it can slightly degrade the source selection performance for SFFT subtraction. This is indeed weird but that is why I inserted the version constrain.

If you are using your forked version, I would suggest you to remove this version constrain for a quick fix. For most cases, it will make no/trivial difference after you remove this line. I was planing to extract the Hough Transform function of proper version Scikit-image so that I can simply remove this constrain for next versions of SFFT. I have not yet got a chance to finish this. But this is definitely a thing what I need to do as Scikit-image 18.3 also incompatiable with the lastest Python 12. I will keep you posted for the new version development. Also, thank you for bringing this up!!