search

thomasvs / morituri

For those about to RIP - a Unix CD ripper preferring accuracy over speed
GNU General Public License v3.0
301 stars 42 forks source link

Shouldn't calculate the accurip checksums if the disc isn't in the accurip DB #125

Open AdamWill opened 9 years ago

AdamWill commented 9 years ago

From the console output, it looks like morituri checks whether the album is in the accurip DB before calculating the checksums - but even when it isn't, goes ahead and calculates them anyway. What's the point? It's just a waste of time. It already knows it has nothing to compare them to.

This is with latest git master.

thomasvs commented 9 years ago

The checksums go into the log. The accurip checksums may land in the db at a later date, at which time the logs can then be compared to the db. Presumably that is why EAC puts them in the logs as well, and why they are required by certain sites.

ArchangeGabriel commented 9 years ago

@thomasvs: Yes, exactly.

baldurmen commented 8 years ago

This does not look like a bug and should thus be closed :D