thomasvs / morituri

For those about to RIP - a Unix CD ripper preferring accuracy over speed
GNU General Public License v3.0
301 stars 42 forks source link

%s and %S crashed #126

Open toolforger opened 9 years ago

toolforger commented 9 years ago

CD is not listed on MusicBrainz, maybe that's the cause. This is with 01f07c5 applied manually.

$rip \
  cd rip \
  --output-directory="/home/jo/Musik/!ausgelesen" \
  --disc-template="%A/%d - %y" \
  --track-template="%A/%d - %y - %s" \
  --unknown
Using configured read offset 667
Checking device /dev/sr0
CDDB disc id: 8e0fbc09                        
MusicBrainz disc id sugM_d0VIU_49ErYH44MqnE3twE-
MusicBrainz lookup URL http://mm.musicbrainz.org/bare/cdlookup.html?toc=1+9+302318+150+58454+98304+141311+172117+185706+221173+256416+282043&tracks=9&id=sugM_d0VIU_49ErYH44MqnE3twE-
Disc duration: 01:07:08.906, 9 audio tracks
Error: NotFoundException(ResponseError(),)
Continuing without metadata
Submit this disc to MusicBrainz at the above URL.

FreeDB identifies disc as Magdalen Nabb / Tod eines Engl�nders CD01
Creating output directory /home/jo/Musik/!ausgelesen/Unknown Artist
Traceback (most recent call last):
  File "/usr/bin/rip", line 41, in <module>
    sys.exit(main.main(sys.argv[1:]))
  File "/usr/lib/python2.7/dist-packages/morituri/rip/main.py", line 45, in main
    ret = c.parse(argv)
  File "/usr/lib/python2.7/dist-packages/morituri/rip/main.py", line 123, in parse
    logcommand.LogCommand.parse(self, argv)
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 363, in parse
    ret = self.do(args)
  File "/usr/lib/python2.7/dist-packages/morituri/rip/cd.py", line 164, in do
    self.doCommand()
  File "/usr/lib/python2.7/dist-packages/morituri/rip/cd.py", line 444, in doCommand
    ripIfNotRipped(i + 1)
  File "/usr/lib/python2.7/dist-packages/morituri/rip/cd.py", line 338, in ripIfNotRipped
    + '.' + profile.extension
  File "/usr/lib/python2.7/dist-packages/morituri/common/program.py", line 288, in getPath
    ret = os.path.join(outdir, template % v)
KeyError: u's'

Here's the traceback with %S instead of %s:

Traceback (most recent call last):
  File "/usr/bin/rip", line 41, in <module>
    sys.exit(main.main(sys.argv[1:]))
  File "/usr/lib/python2.7/dist-packages/morituri/rip/main.py", line 45, in main
    ret = c.parse(argv)
  File "/usr/lib/python2.7/dist-packages/morituri/rip/main.py", line 123, in parse
    logcommand.LogCommand.parse(self, argv)
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/dist-packages/morituri/extern/command/command.py", line 363, in parse
    ret = self.do(args)
  File "/usr/lib/python2.7/dist-packages/morituri/rip/cd.py", line 164, in do
    self.doCommand()
  File "/usr/lib/python2.7/dist-packages/morituri/rip/cd.py", line 294, in doCommand
    profile=profile, disambiguate=disambiguate)
  File "/usr/lib/python2.7/dist-packages/morituri/common/program.py", line 288, in getPath
    ret = os.path.join(outdir, template % v)
KeyError: u'S'