thomasvs / morituri

For those about to RIP - a Unix CD ripper preferring accuracy over speed
GNU General Public License v3.0
301 stars 42 forks source link

error on not-ascii char in MusicBrainz ID (I think) #65

Closed jhsnyder closed 10 years ago

jhsnyder commented 10 years ago

$ rip cd -d /dev/sr0 rip -U Using configured read offset 6 Checking device /dev/sr0 CDDB disc id: 230c7f05
MusicBrainz disc id PNXte43_tAiZQTksPsD3F_mPYto- MusicBrainz lookup URL http://mm.musicbrainz.org/bare/cdlookup.html?toc=1+5+240107+182+63182+90857+165782+195782&tracks=5&id=PNXte43_tAiZQTksPsD3F_mPYto- Disc duration: 00:53:19.000, 5 audio tracks

Matching releases:

Artist : Hector Berlioz; Orchestre R��volutionnaire et Romantique, Sir John Eliot Gardiner Title : Symphonie fantastique Duration: 00:53:19.172 URL : http://musicbrainz.org/release/8ec2065b-92c3-468d-8d9a-423cfc9a0801 Release : 8ec2065b-92c3-468d-8d9a-423cfc9a0801 Type : Album

\ Message: pygobject_register_sinkfunc is deprecated (GstObject) Traceback (most recent call last):
File "/usr/bin/rip", line 39, in sys.exit(main.main(sys.argv[1:])) File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 45, in main ret = c.parse(argv) File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 123, in parse logcommand.LogCommand.parse(self, argv) File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 401, in parse return self.subCommands[command].parse(args[1:]) File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 401, in parse return self.subCommands[command].parse(args[1:]) File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 363, in parse ret = self.do(args) File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 154, in do self.doCommand() File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 286, in doCommand if os.path.exists(dirname): File "/usr/lib/python2.7/genericpath.py", line 18, in exists os.stat(path) UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 48: ordinal not in range(128) $

Why?

thomasvs commented 10 years ago

Which locale setting do you use? Please provide a debug log too.

jhsnyder commented 10 years ago

Ah, that's the problem, thanks.

System LANG is en_US.UTF-8 but I generally run with LANG=C.

I have a few questions about usage & terminology that I haven't been able to answer from the man page / release notes or trial-and-error or online search.

Should I ask here or would you prefer that I open a new comment thread?

If the latter, open here (github) or at your home trac page?

Appreciate your time.

thomasvs commented 10 years ago

I guess as separate issues here works, that way people can find it later.