run morituri offset find. A message appears on the screen:
Scanning disc... (1 of 1) ... 0 %
followed by
Reading TOC of session 1... (2 of 2) ... 0 %
When I see "(1 of 1)", I expect that this is the only task in the group, and when it is done the group is done. I find it confusing to have (2 of 2) suddenly appear.
Expected behaviour:
Either have the Scanning disc message anticipate a reading TOC message, e.g.:
Scanning disc... (1 of 2) ... 0 %
Reading TOC of session 1... (2 of 2) ... 0 %
Or give a message that a new task has been added:
Scanning disc... (1 of 1) ... 0 %
1 more task added. New total: 2
Reading TOC of session 1... (2 of 2) ... 0 %
Other information:
I'm guessing that the logic for "1 of 1" is that the task.MultiSeparateTask class, which is what supplies the "1 of 1" text, has only 1 task in its task list at first.
The task list gets set up in ReadAllSessionsTask.init(). One approach is to add a placeholder second task then, or to go ahead and add the Session 1 task then. New tasks get added in ReadAllSessionsTask.stopped(). Another approach is to add a line emitting message about adding tasks in that method.
This is merely a cosmetic issue, but it bugs me enough to write it down.
run
morituri offset find. A message appears on the screen:followed by
When I see "(1 of 1)", I expect that this is the only task in the group, and when it is done the group is done. I find it confusing to have (2 of 2) suddenly appear.
Expected behaviour: Either have the Scanning disc message anticipate a reading TOC message, e.g.:
Or give a message that a new task has been added:
Other information:
I'm guessing that the logic for "1 of 1" is that the task.MultiSeparateTask class, which is what supplies the "1 of 1" text, has only 1 task in its task list at first.
The task list gets set up in ReadAllSessionsTask.init(). One approach is to add a placeholder second task then, or to go ahead and add the Session 1 task then. New tasks get added in ReadAllSessionsTask.stopped(). Another approach is to add a line emitting message about adding tasks in that method.
This is merely a cosmetic issue, but it bugs me enough to write it down.