thomasvs / morituri

For those about to RIP - a Unix CD ripper preferring accuracy over speed
GNU General Public License v3.0
301 stars 42 forks source link

rip offset find fails to delete temporary .wav files, if error while ripping #75

Open JDLH opened 10 years ago

JDLH commented 10 years ago

I ran rip offset find on a Linux system. Morituri tried to rip and verify Accurip checksum with its list of several dozen offsets, as expected. However, a few of the offset values yielded an error message. After Morituri finished, there were a few .wav files left in /tmp. Their file names corresponded to the offsets which yielded an error message.

Observed behaviour .wav files with Morituri-related filenames remained in the temporary files directory.

Expected behaviour Morituri deletes all the .wav it creates in the course of rip offset find.

JDLH commented 10 years ago

Here are the stdout messages from rip offset find, followed by a list of the *.wav files in /tmp afterwards. I expect zero .wav files, there are non-zero. And the offset numbers in the file names seem to correspond to the offset numbers in the error messages.

$ rip offset find -d /dev/cdrom1
Checking device Device('/dev/cdrom1')
Trying read offset 6 ...                      
Trying read offset 48 ...                     
Trying read offset 102 ...                    
Trying read offset 667 ...                    
Trying read offset 12 ...                     
Trying read offset 30 ...                     
Trying read offset 618 ...                    
Trying read offset 594 ...                    
Trying read offset 738 ...                    
Trying read offset -472 ...                   
WARNING: cannot rip with offset -472...       
Trying read offset 98 ...
Trying read offset 116 ...                    
Trying read offset 96 ...                     
Trying read offset 733 ...                    
Trying read offset 120 ...                    
Trying read offset 691 ...                    
Trying read offset 685 ...                    
Trying read offset 97 ...                     
Trying read offset 600 ...                    
Trying read offset 690 ...                    
Trying read offset 1292 ...                   
Trying read offset 99 ...                     
Trying read offset 676 ...                    
Trying read offset 686 ...                    
Trying read offset 1182 ...                   
Trying read offset -24 ...                    
WARNING: cannot rip with offset -24...        
Trying read offset 704 ...
Trying read offset 572 ...                    
Trying read offset 688 ...                    
Trying read offset 91 ...                     
Trying read offset 696 ...                    
Trying read offset 103 ...                    
Trying read offset -491 ...                   
WARNING: cannot rip with offset -491...       
Trying read offset 689 ...
Trying read offset 145 ...                    
Trying read offset 708 ...                    
Trying read offset 697 ...                    
Trying read offset 564 ...                    
Trying read offset 86 ...                     
Trying read offset 679 ...                    
Trying read offset 355 ...                    
Trying read offset -496 ...                   
WARNING: cannot rip with offset -496...       
Trying read offset -1164 ...
WARNING: cannot rip with offset -1164...      
Trying read offset 1160 ...
Trying read offset 694 ...                    
Trying read offset 0 ...                      
Trying read offset -436 ...                   
WARNING: cannot rip with offset -436...       
Trying read offset 79 ...
Trying read offset 94 ...                     
Trying read offset 684 ...                    
Trying read offset 681 ...                    
Trying read offset 106 ...                    
Trying read offset 692 ...                    
Trying read offset 943 ...                    
Trying read offset 1194 ...                   
Trying read offset 92 ...                     
Trying read offset 117 ...                    
Trying read offset 680 ...                    
Trying read offset 682 ...                    
Trying read offset 1268 ...                   
Trying read offset 678 ...                    
Trying read offset -582 ...                   
WARNING: cannot rip with offset -582...       
Trying read offset 1473 ...
Trying read offset 1279 ...                   
Trying read offset -54 ...                    
WARNING: cannot rip with offset -54...        
Trying read offset 1508 ...
Trying read offset 740 ...                    
Trying read offset 1272 ...                   
Trying read offset 534 ...                    
Trying read offset 976 ...                    
Trying read offset 687 ...                    
Trying read offset 675 ...                    
Trying read offset 1303 ...                   
Trying read offset 674 ...                    
Trying read offset 1263 ...                   
Trying read offset 108 ...                    
Trying read offset 974 ...                    
Trying read offset 122 ...                    
Trying read offset 111 ...                    
Trying read offset -489 ...                   
WARNING: cannot rip with offset -489...       
Trying read offset 772 ...
Trying read offset 732 ...                    
Trying read offset -495 ...                   
WARNING: cannot rip with offset -495...       
Trying read offset -494 ...
WARNING: cannot rip with offset -494...       
Trying read offset 975 ...
Trying read offset 935 ...                    
Trying read offset 87 ...                     
Trying read offset 668 ...                    
Trying read offset 1776 ...                   
Trying read offset 1364 ...                   
Trying read offset 1336 ...                   
Trying read offset 1127 ...                   
No matching offset found.                     
Consider trying again with a different disc.
$

and here is a directory listing of the temporary files directory /tmp afterwards (irrelevant files omitted):

$ ls -l /tmp/*.wav
-rw------- 1 user user 69986156 Mar 20 02:54 /tmp/tmp9R1XG5.track01.offset-495.morituri.wav
-rw------- 1 user user 69986156 Mar 20 02:54 /tmp/tmpeLpjin.track01.offset-494.morituri.wav
-rw------- 1 user user 69986156 Mar 20 01:27 /tmp/tmpEV8f6n.track01.offset-491.morituri.wav
-rw------- 1 user user 69986156 Mar 20 02:49 /tmp/tmpnJr43E.track01.offset-489.morituri.wav
-rw------- 1 user user 69986156 Mar 20 02:17 /tmp/tmpOfq2oc.track01.offset-582.morituri.wav
-rw------- 1 user user 69986156 Mar 20 02:22 /tmp/tmppoiI3u.track01.offset-54.morituri.wav
-rw------- 1 user user 69986156 Mar 20 01:49 /tmp/tmpQOM1hG.track01.offset-436.morituri.wav
-rw------- 1 user user       44 Mar 20 01:43 /tmp/tmpqRwq5j.track01.offset-1164.morituri.wav
-rw------- 1 user user 69986156 Mar 20 00:45 /tmp/tmpUnlhSg.track01.offset-472.morituri.wav
-rw------- 1 user user 69986156 Mar 20 01:14 /tmp/tmpUTZMx4.track01.offset-24.morituri.wav
-rw------- 1 user user 69986156 Mar 20 01:43 /tmp/tmpZ12mon.track01.offset-496.morituri.wav
$