don't keep short HTOA's if their peak level is low

thomasvs / morituri

For those about to RIP - a Unix CD ripper preferring accuracy over speed

GNU General Public License v3.0

301 stars 42 forks source link

don't keep short HTOA's if their peak level is low #79

Open RecursiveForest opened 10 years ago

RecursiveForest commented 10 years ago

Right now morituri will blindly rip PREGAPs before the first track, even if they're silent. This simple patch lets morituri rip the PREGAP, then checks the rip's peak level as reported by cdparanoia to see whether it's below "SILENT" or not (default to 1e-10). If it's silent, it quietly removes the evidence from the log and cue and carries on with the rip, otherwise the original bevahiour is kept.

kevmitch commented 10 years ago

isn't the data stored as integers, in which case you should safely be able to make SILENT=0?

ArchangeGabriel commented 9 years ago

What’s the status of this?

salixh5 commented 9 years ago

I'm also interested in better HTOA handling.

ArchangeGabriel commented 9 years ago

@thomasvs Could you please state here what’s wrong with this PR? Thanks a lot. :)

dogo77 commented 9 years ago

hi! any chance that this PR will be accepted? a simple yes or no is enough! :smile: anyways, thanks for developing morituri!

thomasvs commented 9 years ago

Something like this will. It needs some interrupted time from me for testing, and I want to make sure it does this only when the silence is absolute - i.e. 100% identical to zero.

salixh5 commented 9 years ago

Is there anything one could possibly do to help with testing?

Whovian9369 commented 9 years ago

+1 to this idea from me

Eriner commented 9 years ago

@thomasvs have you taken time to look at and test this PR?

thomasvs commented 9 years ago

On 09/06/2015 03:04 PM, Matt Hamilton wrote:

@thomasvs https://github.com/thomasvs have you taken time to look at and test this PR?

— Reply to this email directly or view it on GitHub https://github.com/thomasvs/morituri/pull/79#issuecomment-138114792.

No, not yet. I've bought an external cd rom that I think should handle HTOA (as I don't have my desktop anymore after the move) so I hope to do so soon.

Honeymoon's Great Wish You Were Her

savon - Saving your work to svn https://apestaart.org/thomas/trac/

Eriner commented 9 years ago

Great. I'll ping you again in a week or so to bother you about it :)