.cue file includes wrong offset for INDEX > 1

[Hawke]

When ripping a CD which contains sub-track indexes, morituri does not list the proper offsets for indexes other than one.

An excerpt from a .cue file from such a CD:

FILE "07. The Mermen - Brain Wash: I. What Am I Always Waiting For?-II. A Kiss-III. Rumination-IIII. I of the Moo.flac" WAVE TRACK 07 AUDIO INDEX 01 00:00:00 INDEX 02 -22:39:70 INDEX 03 -19:17:62 INDEX 04 -17:58:72

Obviously those negative indexes are not valid.

[thomasvs]

Can you tell me which version, and give me a full RIP_DEBUG=5 log so I can see?

[Hawke]

Version is current git. RIP_DEBUG=5 log: https://gist.githubusercontent.com/Hawke/17e3b2589b36206c3fb2/raw/debug.log

Note: debug log creates a cue file which corresponds with the previously-mentioned excerpt.

[thomasvs]

The first log line states that this is version 0.2.0

Current git version is 0.2.2.1

It doesn't look like you're using the latest git version. Can you make sure you're running the latest git version and try again?

[Hawke]

Aargh. Apparently 'morituri-uninstalled' does not override the rip command if morituri is otherwise installed in /usr/bin already.

Well, this seems to be fixed in current version. Thanks!

[thomasvs]

Well that's good news, as one of the reasons for releasing the next version is fixing exactly this issue.

morituri-uninstalled should totally prefer the uninstalled rip binary, are you sure it doesn't?

thomas@otto ~]$ morituri-git Entering interactive morituri shell /bin/bash (with bash completion) (b:master d:v0.2.2-80-g222d0b1) [morituri-git](b:master d:v0.2.2-80-g222d0b1) [thomas@otto morituri]$ which rip ~/dev/own/morituri/bin/rip

[Hawke]

I have two problems in that regard: ~$ morituri-git bash: cd: ../Documents/Source/git/morituri/misc/..: No such file or directory Entering interactive morituri shell /bin/bash (with bash completion) ~$ which rip /usr/bin/rip

(n.b. 'morituri git' is in ~/bin) So it looks like it’s not finding the proper path.

Second: ~/bin$ morituri-git Entering interactive morituri shell /bin/bash (with bash completion) ~/Documents/Source/git/morituri$ which rip /[$HOME]/Documents/Source/git/morituri/bin/rip

So if I run it like that, it at leasts find the right 'rip'…but: ~/Documents/Source/git/morituri$ rip cd rip Traceback (most recent call last): File "/[$HOME]/Documents/Source/git/morituri/bin/rip", line 36, in from morituri.common import deps ImportError: cannot import name deps

I get that import error unless I uninstall the distro-provided morituri (Ubuntu 14.04, so version 0.2.0)

[thomasvs]

On 07/01/2014 11:13 AM, Alex Mauer wrote:

I have two problems in that regard: ~$ morituri-git bash: cd: ../Documents/Source/git/morituri/misc/..: No such file or directory Entering interactive morituri shell /bin/bash (with bash completion) ~$ which rip /usr/bin/rip

(n.b. 'morituri git' is in ~/bin) So it looks like it’s not finding the proper path.

is morituri-git a symlink to morituri-uninstalled? Is it correct (ie not broken, pointing to the right path) ?

Second: ~/bin$ morituri-git Entering interactive morituri shell /bin/bash (with bash completion)

Hm... so it works when you're in bin? Then the only thing I can think of is that you may have done a relative symlink when you should have done an absolute symlink. Is that the case?

[Hawke]

Yes, it is a relative symlink. Fixed that.

The second problem still exists though

[thomasvs]

On 07/01/2014 11:48 AM, Alex Mauer wrote:

Yes, it is a relative symlink. Fixed that.

The second problem still exists though

— Reply to this email directly or view it on GitHub https://github.com/thomasvs/morituri/issues/85#issuecomment-47673329.

Ok,

so let's look at output of

set | grep PYTHONPATH

and give me an ls of every morituri directory that is in PYTHONPATH?

[Hawke]

PYTHONPATH=/$HOME/Documents/Source/git/morituri

(note, $HOME is actually the path to my home dir, not literally '$HOME')

~/Documents/Source/git/morituri$ ls aclocal.m4 config.log examples Makefile.in NEWS AUTHORS config.status HACKING misc py-compile autogen.sh configure INSTALL missing README autom4te.cache configure.ac install-sh morituri README.md autoregen.sh COPYING m4 morituri.doap RELEASE bin doc Makefile morituri.spec TODO ChangeLog etc Makefile.am morituri.spec.in

[thomasvs]

Ok, try:

python

import morituri morituri

and show me the output of that

if that works, then try

import morituri.common morituri.common import morituri.common.deps morituri.common.deps

[Freso]

ImportError: cannot import name deps

Did you checkout/init/update the Git submodules?