thomasw / djproxy

djproxy is a class-based generic view reverse HTTP proxy for Django.
MIT License
42 stars 15 forks source link

Send X-Forwarded-Proto downstream #17

Closed blaix closed 9 years ago

blaix commented 9 years ago

This helps the proxied service know if a request is secure even if there's an http/https mismatch up/downstream.

Related: https://docs.djangoproject.com/en/1.6/ref/settings/#secure-proxy-ssl-header

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.07%) to 97.9% when pulling 641e542c894ac2f23292becb22beb31ab39c0ce3 on yola:x_forwarded_proto into 7dfc51661e6d5d63e2865adcf30c564b7b0104b3 on thomasw:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.07%) to 97.9% when pulling 641e542c894ac2f23292becb22beb31ab39c0ce3 on yola:x_forwarded_proto into 7dfc51661e6d5d63e2865adcf30c564b7b0104b3 on thomasw:master.

blaix commented 9 years ago

bumping that coverage one baby step at a time...

thomasw commented 9 years ago

This looks good. I think this should also be added to the default middleware list: https://github.com/thomasw/djproxy/blob/master/djproxy/views.py#L24-L28

It already sends X-Forwarded-Host by default.

blaix commented 9 years ago

added

blaix commented 9 years ago

:bell: