Closed hugovk closed 4 years ago
Thank you for your pull request and information.
I had committed some workaround to fix CI for Python 2. However, I might need to reconsider test scripts.
I will review the code, probably this weekend.
LGTM. Thanks.
You're welcome, thanks for pytablewriter!
The Python 2.7 build is failing:
It looks like it's because tox is running
python setup.py test
which is installing dependencies without using pip, and sopython_requires
is ignored, and so tries to install newest versions which don't support Python 2 any more.I think
python setup.py test
is no longer recommended, and it would be better to do something likepip install .
(orpip install -e .
) andpytest etc
.Whilst that would still be a good idea, another idea is also to drop Python 2 support here.
Here's the pip installs for pytablewriter from PyPI for January 2020:
Source:
pip install -U pypistats && pypistats python_minor pytablewriter --last-month